From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next] netfilter: x_table: speedup compat operations Date: Wed, 12 Jan 2011 22:14:25 +0100 Message-ID: <1294866865.3335.3.camel@edumazet-laptop> References: <1292693715.18869.148.camel@edumazet-laptop> <4D2E12B9.6090201@netfilter.org> <1294866229.3335.2.camel@edumazet-laptop> <4D2E18E5.4000902@netfilter.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Patrick McHardy , David Miller , Netfilter Development Mailinglist , netdev To: Pablo Neira Ayuso Return-path: In-Reply-To: <4D2E18E5.4000902@netfilter.org> Sender: netfilter-devel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Le mercredi 12 janvier 2011 =C3=A0 22:11 +0100, Pablo Neira Ayuso a =C3= =A9crit : > On 12/01/11 22:03, Eric Dumazet wrote: > > Le mercredi 12 janvier 2011 =C3=A0 21:44 +0100, Pablo Neira Ayuso a= =C3=A9crit : > >=20 > >> minor glitch: We leak xp->compat_tab if this error condition above= is true. > >> > >=20 > > I dont think so, pointer is stored in xp->compat_tab > >=20 > > xt_compat_flush_offsets() will free it. >=20 > Indeed, sorry. I'm going apply your patch. Thanks Eric. Thanks ! I completely forgot about it, to be honest :) -- To unsubscribe from this list: send the line "unsubscribe netfilter-dev= el" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html