netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tobias Klauser <tklauser@distanz.ch>
To: David Miller <davem@davemloft.net>,
	cmetcalf@tilera.com, netdev@vger.kernel.org
Cc: tklauser@distanz.ch
Subject: [PATCH net-next-2.6] etherdevice.h: Add is_unicast_ether_addr function
Date: Thu, 13 Jan 2011 09:14:56 +0100	[thread overview]
Message-ID: <1294906496-14950-1-git-send-email-tklauser@distanz.ch> (raw)
In-Reply-To: <20110112.234250.10542369.davem@davemloft.net>

>From a check for !is_multicast_ether_addr it is not always obvious that
we're checking for a unicast address. So add this helper function to
make those code paths easier to read.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
 include/linux/etherdevice.h |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h
index bec8b82..ab68f78 100644
--- a/include/linux/etherdevice.h
+++ b/include/linux/etherdevice.h
@@ -99,6 +99,17 @@ static inline int is_broadcast_ether_addr(const u8 *addr)
 }
 
 /**
+ * is_unicast_ether_addr - Determine if the Ethernet address is unicast
+ * @addr: Pointer to a six-byte array containing the Ethernet address
+ *
+ * Return true if the address is a unicast address.
+ */
+static inline int is_unicast_ether_addr(const u8 *addr)
+{
+	return !is_multicast_ether_addr(addr);
+}
+
+/**
  * is_valid_ether_addr - Determine if the given Ethernet address is valid
  * @addr: Pointer to a six-byte array containing the Ethernet address
  *
-- 
1.7.0.4


  parent reply	other threads:[~2011-01-13  8:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-12  9:31 [PATCH net-next-2.6] netdev: tilepro: Use is_multicast_ether_addr helper Tobias Klauser
2011-01-12 17:49 ` Chris Metcalf
2011-01-13  2:45   ` David Miller
2011-01-13  6:58     ` Tobias Klauser
2011-01-13  7:42       ` David Miller
2011-01-13  8:13         ` Tobias Klauser
2011-01-13  8:14         ` Tobias Klauser [this message]
2011-01-13  8:24           ` [PATCH net-next-2.6] etherdevice.h: Add is_unicast_ether_addr function Joe Perches
2011-01-13  8:35             ` Tobias Klauser
2011-01-13  8:43               ` Joe Perches
2011-01-13  8:55             ` Eric Dumazet
2011-01-13 16:38               ` Chris Metcalf
2011-01-13 20:35                 ` David Miller
2011-01-14  5:51           ` David Miller
2011-01-13  8:15         ` [PATCH v2 net-next-2.6] netdev: tilepro: Use is_unicast_ether_addr helper Tobias Klauser
2011-01-14  5:51           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1294906496-14950-1-git-send-email-tklauser@distanz.ch \
    --to=tklauser@distanz.ch \
    --cc=cmetcalf@tilera.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).