From: Eric Dumazet <eric.dumazet@gmail.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Patrick McHardy <kaber@trash.net>, jamal <hadi@cyberus.ca>,
Jarek Poplawski <jarkao2@gmail.com>
Subject: Re: [PATCH] net_sched: accurate bytes/packets stats/rates
Date: Fri, 14 Jan 2011 19:08:22 +0100 [thread overview]
Message-ID: <1295028502.3937.116.camel@edumazet-laptop> (raw)
In-Reply-To: <20110114095201.4fc58a45@nehalam>
Le vendredi 14 janvier 2011 à 09:52 -0800, Stephen Hemminger a écrit :
> By using __qdisc_queue_drop_head in sch_fifo.c the stats_update parameter won't be
> needed.
Hmm, this is a constant parameter in inline function so removed by
compiler.
And you add a bug in pfifo_tail_enqueue(), it now lacks the
sch->qstats.drops++;
>
> From Eric Dumazet <eric.dumazet@gmail.com>
>
Note : This line should be the first one in mail ;)
next prev parent reply other threads:[~2011-01-14 18:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 16:16 [PATCH] net_sched: accurate bytes/packets stats/rates Eric Dumazet
2011-01-14 17:52 ` Stephen Hemminger
2011-01-14 18:08 ` Eric Dumazet [this message]
2011-01-14 19:03 ` Stephen Hemminger
2011-01-14 19:21 ` Eric Dumazet
2011-01-16 22:35 ` Jarek Poplawski
2011-01-17 0:09 ` Changli Gao
2011-01-17 7:17 ` Eric Dumazet
2011-01-17 9:16 ` Hagen Paul Pfeifer
2011-01-17 6:54 ` Eric Dumazet
2011-01-21 7:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295028502.3937.116.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=jarkao2@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox