From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: jesse@nicira.com, bhutchings@solarflare.com, netdev@vger.kernel.org
Subject: Re: [BUG] bnx2 + vlan + TSO : doesnt work
Date: Tue, 18 Jan 2011 07:21:30 +0100 [thread overview]
Message-ID: <1295331690.3362.522.camel@edumazet-laptop> (raw)
In-Reply-To: <20110117.220927.189715926.davem@davemloft.net>
Le lundi 17 janvier 2011 à 22:09 -0800, David Miller a écrit :
> From: Jesse Gross <jesse@nicira.com>
> Date: Mon, 17 Jan 2011 16:13:18 -0800
>
> > I think it is better for netif_skb_features() to actually return the
> > correct features rather than bypass it here. NETIF_F_HW_VLAN_TX
> > doesn't depend on any other offloads, so we can always include it if
> > it is in dev->features.
> >
> > Separately, this means there is a problem with bnx2 because it allows
> > vlan insertion to be turned off, which would have the same effect.
> > Maybe it is looking directly at skb->protocol or similar for TSO.
>
> Please, someone cons up an acceptable fix fast.
>
I just woke up, and honestly dont understand why only bnx2 is affected
by this problem of masking NETIF_F_HW_VLAN_TX
And I dont understand all this netif_skb_features() stuff : if we want
to actually test dev->features & NETIF_F_HW_VLAN_TX, and this flag
doesnt depend on other offloads, why are we doing features &
vlan_features.
Jesse, I dont understand why you say "bnx2 allows vlan insertion to be
turned off". Really.
next prev parent reply other threads:[~2011-01-18 6:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 23:41 [BUG] bnx2 + vlan + TSO : doesnt work Eric Dumazet
2011-01-17 23:47 ` Ben Hutchings
2011-01-18 0:00 ` Eric Dumazet
2011-01-18 0:09 ` Ben Hutchings
2011-01-18 0:13 ` Jesse Gross
2011-01-18 6:09 ` David Miller
2011-01-18 6:21 ` Eric Dumazet [this message]
2011-01-18 6:32 ` Jesse Gross
2011-01-18 6:38 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295331690.3362.522.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox