From: Eric Dumazet <eric.dumazet@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Jesper Dangaard Brouer <hawk@diku.dk>,
Jarek Poplawski <jarkao2@gmail.com>, jamal <hadi@cyberus.ca>
Subject: Re: [PATCH net-next-2.6] net_sched: RCU conversion of stab
Date: Thu, 20 Jan 2011 17:39:22 +0100 [thread overview]
Message-ID: <1295541562.2825.368.camel@edumazet-laptop> (raw)
In-Reply-To: <4D384E2D.5050001@trash.net>
Le jeudi 20 janvier 2011 à 16:01 +0100, Patrick McHardy a écrit :
> Am 20.01.2011 14:48, schrieb Eric Dumazet:
> > This patch converts stab qdisc management to RCU, so that we can perform
> > the qdisc_calculate_pkt_len() call before getting qdisc lock.
> >
> > This shortens the lock's held time in __dev_xmit_skb().
> >
> > This permits more qdiscs to get TCQ_F_CAN_BYPASS status, avoiding lot of
> > cache misses and so reducing latencies.
> >
>
> Looks good to me.
>
Thanks for reviewing Patrick !
next prev parent reply other threads:[~2011-01-20 16:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 9:50 [PATCH net-next-2.6] net_sched: sfq: allow divisor to be a variable Eric Dumazet
2011-01-20 10:17 ` Eric Dumazet
2011-01-20 13:48 ` [PATCH net-next-2.6] net_sched: RCU conversion of stab Eric Dumazet
2011-01-20 15:01 ` Patrick McHardy
2011-01-20 16:39 ` Eric Dumazet [this message]
2011-01-20 15:27 ` [PATCH net-next-2.6] net_sched: move TCQ_F_THROTTLED flag Eric Dumazet
2011-01-21 0:56 ` David Miller
2011-01-21 11:04 ` [PATCH net-next-2.6] net_sched: TCQ_F_CAN_BYPASS generalization Eric Dumazet
2011-01-22 0:27 ` David Miller
2011-01-21 0:56 ` [PATCH net-next-2.6] net_sched: RCU conversion of stab David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295541562.2825.368.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=hawk@diku.dk \
--cc=jarkao2@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox