Re: [PATCH] e1000: add support for Marvell Alaska M88E1118R PHY

[Dirk Brandewie <dirk.j.brandewie@intel.com>]

On Wed, 2011-01-19 at 22:51 -0800, Jeff Kirsher wrote:
> On Wed, Jan 19, 2011 at 01:09, Florian Fainelli <ffainelli@freebox.fr> wrote:
> > From: Florian Fainelli <ffainelli@freebox.fr>
> >
> > This patch adds support for Marvell Alask M88E188R PHY chips. Support for
> > other M88* PHYs is already there, so there is nothing more to add than its
> > PHY id.
> >
> > Signed-off-by: Florian Fainelli <ffainelli@freebox.fr>
> > CC: Dirk Brandewie <dirk.j.brandewie@intel.com>
> > CC: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> > ---
> 
> The patch itself looks fine.  I am concerned about validation.
> 
> Dirk - is there a chance that the ce4100 will use this PHY?  If so,
> can you cover the validation?

Florian is working on a CE4100 based platform.  It looks like they used
a different PHY from the Flacon Falls reference platform. I can't
directly test this patch since I don't have their hardware.  I will be
testing .38-rc1 next week on falcon falls.

I think the best we can do without the hardware is to compare the data
sheet for the new PHY with the PHYs already supported and make sure they
are compatible.  If the datasheets match up for the features the driver
is using this seems pretty low risk IMHO.

--Dirk
> 
> For now I will add this to my net-next tree while I await word from Dirk.
>