From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: netdev@vger.kernel.org, Ben Hutchings <bhutchings@solarflare.com>
Subject: Re: [PATCH v2 02/16] net: change netdev->features to u32
Date: Sun, 23 Jan 2011 11:35:13 +0100 [thread overview]
Message-ID: <1295778913.17333.28.camel@edumazet-laptop> (raw)
In-Reply-To: <d9fe088556152bd3b43390e0fb5ea20d83aef233.1295734271.git.mirq-linux@rere.qmqm.pl>
Le samedi 22 janvier 2011 à 23:14 +0100, Michał Mirosław a écrit :
> Quoting Ben Hutchings: we presumably won't be defining features that
> can only be enabled on 64-bit architectures.
>
> Occurences found by `grep -r` on net/, drivers/net, include/
>
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> ---
...
> /* Unset features, set them as we chew on the arg. */
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 371fa88..c73d63d 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -894,7 +894,7 @@ struct net_device {
> struct list_head unreg_list;
>
> /* Net device features */
> - unsigned long features;
> + u32 features;
> #define NETIF_F_SG 1 /* Scatter/gather IO. */
> #define NETIF_F_IP_CSUM 2 /* Can checksum TCP/UDP over IPv4. */
> #define NETIF_F_NO_CSUM 4 /* Does not require checksum. F.e. loopack. */
> @@ -1150,7 +1150,7 @@ struct net_device {
> const struct rtnl_link_ops *rtnl_link_ops;
>
> /* VLAN feature mask */
> - unsigned long vlan_features;
> + u32 vlan_features;
>
> /* for setting kernel sock attribute on TCP connection setup */
Could you move "vlan_features" right after "features", so that no holes
are there on 64bit arches ?
next prev parent reply other threads:[~2011-01-23 10:35 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-22 22:14 [PATCH v2 00/16] net: Unified offload configuration Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 03/16] net: reduce and unify printk level in netdev_fix_features() Michał Mirosław
2011-01-22 23:12 ` Joe Perches
2011-01-22 23:40 ` Michał Mirosław
2011-01-23 12:44 ` [PATCH] " Michał Mirosław
2011-01-22 23:48 ` [PATCH v2 03/16] " Michał Mirosław
2011-01-24 23:45 ` David Miller
2011-01-22 22:14 ` [PATCH v2 01/16] net: Move check of checksum features to netdev_fix_features() Michał Mirosław
2011-01-24 23:29 ` David Miller
2011-01-22 22:14 ` [PATCH v2 02/16] net: change netdev->features to u32 Michał Mirosław
2011-01-23 10:35 ` Eric Dumazet [this message]
2011-01-23 12:44 ` [PATCH] " Michał Mirosław
2011-01-24 23:30 ` [PATCH v2 02/16] " David Miller
2011-01-25 11:07 ` Michał Mirosław
2011-01-25 20:37 ` David Miller
2011-01-22 22:14 ` [PATCH v2 07/16] net: introduce NETIF_F_RXCSUM Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 05/16] net: ethtool: use ndo_fix_features for offload setting Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 11/16] bonding: convert to ndo_fix_features Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 08/16] loopback: convert to hw_features Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 06/16] net: use ndo_fix_features for ethtool_ops->set_flags Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 10/16] vlan: convert VLAN devices to use ndo_fix_features() Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 04/16] net: Introduce new feature setting ops Michał Mirosław
2011-01-24 23:51 ` David Miller
2011-01-25 1:26 ` Ben Hutchings
2011-01-22 22:14 ` [PATCH v2 09/16] bridge: convert br_features_recompute() to ndo_fix_features Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 12/16] jme: convert offload constraints " Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 13/16] virtio_net: convert " Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 14/16] Intel net drivers: " Michał Mirosław
2011-01-24 7:06 ` Jeff Kirsher
2011-01-26 9:47 ` Jeff Kirsher
2011-04-07 12:51 ` Michał Mirosław
2011-04-07 15:00 ` Jeff Kirsher
2011-01-22 22:14 ` [PATCH v2 16/16] skge: convert to hw_features Michał Mirosław
2011-01-31 16:45 ` Stephen Hemminger
2011-01-31 21:53 ` Michał Mirosław
2011-01-31 22:40 ` Michał Mirosław
2011-01-31 23:08 ` Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 15/16] veth: " Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295778913.17333.28.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox