netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Socketcan-core@lists.berlios.de
Subject: [PATCH v3 0/3] can: at91_can: fix for errata 50.2.6.3 & 50.3.5.3
Date: Mon, 24 Jan 2011 15:15:29 +0100	[thread overview]
Message-ID: <1295878532-15769-1-git-send-email-mkl@pengutronix.de> (raw)

Hello,

as promised I've implemented the proposed workaround for the errata
50.2.6.3 & 50.3.5.3:
"Contents of Mailbox 0 can be sent Even if Mailbox is Disabled"

This means under high bus load it can happen that the mailbox 0 is send
to the bus. And it does happen, even with the mainline driver where
Mailbox 0 is a receive mailbox. The errata proposes not to use mailbox 0
and load it with an unused can_id that will not disturb the bus.

The first patch cleans up the driver without any functional changes, so
that the mailbox 0 can be disabled in the second patch. The third patch
adds a sysfs parameter to the driver, so that the identifier of mailbox 0
can configured.

This series applies to net-2.6/master. It has been tested on a ronetix pm9263
board against a PCI-SJA1000 card with the canfdtest utility and on custom
at91 boards against each other.

changes since v2:
- rebased to current net-2.6/master
- added Acked-by (Thanks to Kurt Van Dijck, Wolfgang Grandegger
  and Wolfram Sang)

regards, Marc




             reply	other threads:[~2011-01-24 14:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-24 14:15 Marc Kleine-Budde [this message]
2011-01-24 14:15 ` [PATCH v3 2/3] can: at91_can: don't use mailbox 0 Marc Kleine-Budde
     [not found] ` <1295878532-15769-1-git-send-email-mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-01-24 14:15   ` [PATCH v3 1/3] can: at91_can: clean up usage of AT91_MB_RX_FIRST and AT91_MB_RX_NUM Marc Kleine-Budde
2011-01-24 14:15   ` [PATCH v3 3/3] can: at91_can: make can_id of mailbox 0 configurable Marc Kleine-Budde
2011-01-24 14:19   ` [PATCH v3 0/3] can: at91_can: fix for errata 50.2.6.3 & 50.3.5.3 Marc Kleine-Budde
2011-01-24 23:17     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1295878532-15769-1-git-send-email-mkl@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=Socketcan-core@lists.berlios.de \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).