From: Ben Hutchings <bhutchings@solarflare.com>
To: David Miller <davem@davemloft.net>
Cc: mirq-linux@rere.qmqm.pl, netdev@vger.kernel.org
Subject: Re: [PATCH v2 04/16] net: Introduce new feature setting ops
Date: Tue, 25 Jan 2011 11:26:01 +1000 [thread overview]
Message-ID: <1295918761.4105.7.camel@localhost> (raw)
In-Reply-To: <20110124.155144.35028895.davem@davemloft.net>
On Mon, 2011-01-24 at 15:51 -0800, David Miller wrote:
> From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> Date: Sat, 22 Jan 2011 23:14:13 +0100 (CET)
>
> > This introduces a new framework to handle device features setting.
> > It consists of:
> > - new fields in struct net_device:
> > + hw_features - features that hw/driver supports toggling
> > + wanted_features - features that user wants enabled, when possible
> > - new netdev_ops:
> > + feat = ndo_fix_features(dev, feat) - API checking constraints for
> > enabling features or their combinations
> > + ndo_set_features(dev) - API updating hardware state to match
> > changed dev->features
> > - new ethtool commands:
> > + ETHTOOL_GFEATURES/ETHTOOL_SFEATURES: get/set dev->wanted_features
> > and trigger device reconfiguration if resulting dev->features
> > changed
> > + ETHTOOL_GSTRINGS(ETH_SS_FEATURES): get feature bits names (meaning)
> >
> > Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
>
> Ok, I'll stop applying patches right before this one as I'd like to see
> at least some feedback from Ben wrt. the ethtool bits.
>
> FWIW I like these changes (a lot). :-)
These are on my list to review. I'm at LCA now (and not on work time)
but I'll try to get through them in the next day or two.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-01-25 1:26 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-22 22:14 [PATCH v2 00/16] net: Unified offload configuration Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 02/16] net: change netdev->features to u32 Michał Mirosław
2011-01-23 10:35 ` Eric Dumazet
2011-01-23 12:44 ` [PATCH] " Michał Mirosław
2011-01-24 23:30 ` [PATCH v2 02/16] " David Miller
2011-01-25 11:07 ` Michał Mirosław
2011-01-25 20:37 ` David Miller
2011-01-22 22:14 ` [PATCH v2 01/16] net: Move check of checksum features to netdev_fix_features() Michał Mirosław
2011-01-24 23:29 ` David Miller
2011-01-22 22:14 ` [PATCH v2 03/16] net: reduce and unify printk level in netdev_fix_features() Michał Mirosław
2011-01-22 23:12 ` Joe Perches
2011-01-22 23:40 ` Michał Mirosław
2011-01-23 12:44 ` [PATCH] " Michał Mirosław
2011-01-22 23:48 ` [PATCH v2 03/16] " Michał Mirosław
2011-01-24 23:45 ` David Miller
2011-01-22 22:14 ` [PATCH v2 12/16] jme: convert offload constraints to ndo_fix_features Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 10/16] vlan: convert VLAN devices to use ndo_fix_features() Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 04/16] net: Introduce new feature setting ops Michał Mirosław
2011-01-24 23:51 ` David Miller
2011-01-25 1:26 ` Ben Hutchings [this message]
2011-01-22 22:14 ` [PATCH v2 07/16] net: introduce NETIF_F_RXCSUM Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 08/16] loopback: convert to hw_features Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 09/16] bridge: convert br_features_recompute() to ndo_fix_features Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 05/16] net: ethtool: use ndo_fix_features for offload setting Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 11/16] bonding: convert to ndo_fix_features Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 06/16] net: use ndo_fix_features for ethtool_ops->set_flags Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 15/16] veth: convert to hw_features Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 13/16] virtio_net: convert to ndo_fix_features Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 14/16] Intel net drivers: " Michał Mirosław
2011-01-24 7:06 ` Jeff Kirsher
2011-01-26 9:47 ` Jeff Kirsher
2011-04-07 12:51 ` Michał Mirosław
2011-04-07 15:00 ` Jeff Kirsher
2011-01-22 22:14 ` [PATCH v2 16/16] skge: convert to hw_features Michał Mirosław
2011-01-31 16:45 ` Stephen Hemminger
2011-01-31 21:53 ` Michał Mirosław
2011-01-31 22:40 ` Michał Mirosław
2011-01-31 23:08 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295918761.4105.7.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).