From: Changli Gao <xiaosuo@gmail.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
"Pekka Savola (ipv6)" <pekkas@netcore.fi>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
netdev@vger.kernel.org, Changli Gao <xiaosuo@gmail.com>
Subject: [PATCH] net: remove tests on 64bit platforms
Date: Tue, 25 Jan 2011 12:21:38 +0800 [thread overview]
Message-ID: <1295929298-13163-1-git-send-email-xiaosuo@gmail.com> (raw)
On 64bit platforms, >31 bit shifting of a unsigned long variable is
valid, so we can remove the related boundary tests, which may slow
down the CPU if branch prediction fails.
The size of text becomes smaller:
before:
text data bss dec hex filename
15721 16 16 15753 3d89 net/ipv4/fib_trie.o
after:
text data bss dec hex filename
15656 16 16 15688 3d48 net/ipv4/fib_trie.o
Signed-off-by: Changli Gao <xiaosuo@gmail.com>
---
net/ipv4/fib_trie.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c
index 0f28034..95c8bb3 100644
--- a/net/ipv4/fib_trie.c
+++ b/net/ipv4/fib_trie.c
@@ -219,15 +219,23 @@ static inline int tnode_child_length(const struct tnode *tn)
static inline t_key mask_pfx(t_key k, unsigned short l)
{
+#if BITS_PER_LONG > 32
+ return ((u64)k) >> (KEYLENGTH-l) << (KEYLENGTH-l);
+#else
return (l == 0) ? 0 : k >> (KEYLENGTH-l) << (KEYLENGTH-l);
+#endif
}
static inline t_key tkey_extract_bits(t_key a, int offset, int bits)
{
+#if BITS_PER_LONG > 32
+ return (t_key)((u64)a << offset) >> (KEYLENGTH - bits);
+#else
if (offset < KEYLENGTH)
return ((t_key)(a << offset)) >> (KEYLENGTH - bits);
else
return 0;
+#endif
}
static inline int tkey_equals(t_key a, t_key b)
next reply other threads:[~2011-01-25 4:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 4:21 Changli Gao [this message]
2011-01-25 4:28 ` [PATCH] net: remove tests on 64bit platforms Ben Hutchings
2011-01-25 7:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295929298-13163-1-git-send-email-xiaosuo@gmail.com \
--to=xiaosuo@gmail.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).