From: Joe Perches <joe@perches.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, john.r.fastabend@intel.com
Subject: Re: [PATCH net-next-2.6] net_sched: sch_mqprio: dont leak kernel memory
Date: Wed, 26 Jan 2011 13:33:28 -0800 [thread overview]
Message-ID: <1296077608.2448.13.camel@Joe-Laptop> (raw)
In-Reply-To: <1296077287.2631.9.camel@edumazet-laptop>
On Wed, 2011-01-26 at 22:28 +0100, Eric Dumazet wrote:
> Le mercredi 26 janvier 2011 à 13:24 -0800, Joe Perches a écrit :
> > Ugly maybe, but correct, definitely.
> > The same can not be said of the {0}.
> What about fixing real problems Joe ?
What about it? You seem to have fixed it.
> Are you telling me I dont know C ?
All I'm saying is that from a style and auditing
perspective, it's better to use memset for all
structs that are exposed to user space.
Other than that, there's no issue here.
cheers, Joe
next prev parent reply other threads:[~2011-01-26 21:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 17:21 [PATCH net-next-2.6] net_sched: sch_mqprio: dont leak kernel memory Eric Dumazet
2011-01-26 17:43 ` Joe Perches
2011-01-26 17:49 ` Eric Dumazet
2011-01-26 17:56 ` Joe Perches
2011-01-26 19:56 ` David Miller
2011-01-27 11:17 ` Pádraig Brady
2011-01-26 19:55 ` David Miller
2011-01-26 20:23 ` Eric Dumazet
2011-01-26 20:25 ` Eric Dumazet
2011-01-26 21:24 ` Joe Perches
2011-01-26 21:28 ` Eric Dumazet
2011-01-26 21:33 ` Joe Perches [this message]
2011-01-27 6:04 ` Joe Perches
2011-01-27 6:54 ` Changli Gao
2011-01-27 7:04 ` Eric Dumazet
2011-01-26 21:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296077608.2448.13.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox