* [PATCH] vxge: Fix wrong boolean operator
@ 2011-01-28 22:30 Stefan Weil
2011-02-01 4:55 ` David Miller
2011-02-01 7:26 ` [PATCH] vxge: Fix wrong boolean operator {nodisc} Ramkrishna Vepa
0 siblings, 2 replies; 4+ messages in thread
From: Stefan Weil @ 2011-01-28 22:30 UTC (permalink / raw)
To: jon.mason
Cc: Stefan Weil, Ramkrishna Vepa, Sivakumar Subramani,
Sreenivasa Honnur, netdev, linux-kernel
This error is reported by cppcheck:
drivers/net/vxge/vxge-config.c:3693: warning: Mutual exclusion over || always evaluates to true. Did you intend to use && instead?
It looks like cppcheck is correct, so fix this. No test was run.
Cc: Ramkrishna Vepa <ramkrishna.vepa@exar.com>
Cc: Sivakumar Subramani <sivakumar.subramani@exar.com>
Cc: Sreenivasa Honnur <sreenivasa.honnur@exar.com>
Cc: Jon Mason <jon.mason@exar.com>
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
drivers/net/vxge/vxge-config.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/vxge/vxge-config.c b/drivers/net/vxge/vxge-config.c
index 01c05f5..228d4f7 100644
--- a/drivers/net/vxge/vxge-config.c
+++ b/drivers/net/vxge/vxge-config.c
@@ -3690,7 +3690,7 @@ __vxge_hw_vpath_rts_table_get(struct __vxge_hw_vpath_handle *vp,
if (status != VXGE_HW_OK)
goto exit;
- if ((rts_table != VXGE_HW_RTS_ACCESS_STEER_CTRL_DATA_STRUCT_SEL_DA) ||
+ if ((rts_table != VXGE_HW_RTS_ACCESS_STEER_CTRL_DATA_STRUCT_SEL_DA) &&
(rts_table !=
VXGE_HW_RTS_ACS_STEER_CTRL_DATA_STRUCT_SEL_RTH_MULTI_IT))
*data1 = 0;
--
1.7.2.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] vxge: Fix wrong boolean operator
2011-01-28 22:30 [PATCH] vxge: Fix wrong boolean operator Stefan Weil
@ 2011-02-01 4:55 ` David Miller
2011-02-01 7:26 ` [PATCH] vxge: Fix wrong boolean operator {nodisc} Ramkrishna Vepa
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2011-02-01 4:55 UTC (permalink / raw)
To: weil
Cc: jon.mason, ramkrishna.vepa, sivakumar.subramani,
sreenivasa.honnur, netdev, linux-kernel
From: Stefan Weil <weil@mail.berlios.de>
Date: Fri, 28 Jan 2011 23:30:17 +0100
> This error is reported by cppcheck:
> drivers/net/vxge/vxge-config.c:3693: warning: Mutual exclusion over || always evaluates to true. Did you intend to use && instead?
>
> It looks like cppcheck is correct, so fix this. No test was run.
>
> Cc: Ramkrishna Vepa <ramkrishna.vepa@exar.com>
> Cc: Sivakumar Subramani <sivakumar.subramani@exar.com>
> Cc: Sreenivasa Honnur <sreenivasa.honnur@exar.com>
> Cc: Jon Mason <jon.mason@exar.com>
> Cc: netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Can the VXGE folks please review this patch?
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] vxge: Fix wrong boolean operator {nodisc}
2011-01-28 22:30 [PATCH] vxge: Fix wrong boolean operator Stefan Weil
2011-02-01 4:55 ` David Miller
@ 2011-02-01 7:26 ` Ramkrishna Vepa
2011-02-01 20:30 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Ramkrishna Vepa @ 2011-02-01 7:26 UTC (permalink / raw)
To: Stefan Weil
Cc: Sivakumar Subramani, Sreenivasa Honnur, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Jon Mason
> This error is reported by cppcheck:
> drivers/net/vxge/vxge-config.c:3693: warning: Mutual exclusion over ||
> always evaluates to true. Did you intend to use && instead?
>
> It looks like cppcheck is correct, so fix this. No test was run.
>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
> drivers/net/vxge/vxge-config.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/vxge/vxge-config.c b/drivers/net/vxge/vxge-
> config.c
> index 01c05f5..228d4f7 100644
> --- a/drivers/net/vxge/vxge-config.c
> +++ b/drivers/net/vxge/vxge-config.c
> @@ -3690,7 +3690,7 @@ __vxge_hw_vpath_rts_table_get(struct
> __vxge_hw_vpath_handle *vp,
> if (status != VXGE_HW_OK)
> goto exit;
>
> - if ((rts_table != VXGE_HW_RTS_ACCESS_STEER_CTRL_DATA_STRUCT_SEL_DA)
> ||
> + if ((rts_table != VXGE_HW_RTS_ACCESS_STEER_CTRL_DATA_STRUCT_SEL_DA)
> &&
> (rts_table !=
> VXGE_HW_RTS_ACS_STEER_CTRL_DATA_STRUCT_SEL_RTH_MULTI_IT))
> *data1 = 0;
> --
Fix looks good. Thanks!
Acked-by: Ram Vepa <ram.vepa@exar.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] vxge: Fix wrong boolean operator {nodisc}
2011-02-01 7:26 ` [PATCH] vxge: Fix wrong boolean operator {nodisc} Ramkrishna Vepa
@ 2011-02-01 20:30 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2011-02-01 20:30 UTC (permalink / raw)
To: Ramkrishna.Vepa
Cc: weil, Sivakumar.Subramani, Sreenivasa.Honnur, netdev,
linux-kernel, Jon.Mason
From: Ramkrishna Vepa <Ramkrishna.Vepa@exar.com>
Date: Mon, 31 Jan 2011 23:26:40 -0800
>> This error is reported by cppcheck:
>> drivers/net/vxge/vxge-config.c:3693: warning: Mutual exclusion over ||
>> always evaluates to true. Did you intend to use && instead?
>>
>> It looks like cppcheck is correct, so fix this. No test was run.
>>
>> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
...
> Fix looks good. Thanks!
>
> Acked-by: Ram Vepa <ram.vepa@exar.com>
Thanks for reviewing, applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-02-01 20:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-28 22:30 [PATCH] vxge: Fix wrong boolean operator Stefan Weil
2011-02-01 4:55 ` David Miller
2011-02-01 7:26 ` [PATCH] vxge: Fix wrong boolean operator {nodisc} Ramkrishna Vepa
2011-02-01 20:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).