From: Ben Hutchings <bhutchings@solarflare.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ethtool: implement G/SFEATURES calls
Date: Sun, 30 Jan 2011 08:47:35 +1000 [thread overview]
Message-ID: <1296341255.3477.67.camel@localhost> (raw)
In-Reply-To: <4d4fee145908eb232f2766b7d8cbfebaeeffc5e5.1296325736.git.mirq-linux@rere.qmqm.pl>
On Sat, 2011-01-29 at 19:39 +0100, Michał Mirosław wrote:
[...]
> @@ -196,8 +202,8 @@ static struct option {
> " [ rx-mini N ]\n"
> " [ rx-jumbo N ]\n"
> " [ tx N ]\n" },
> - { "-k", "--show-offload", MODE_GOFFLOAD, "Get protocol offload information" },
> - { "-K", "--offload", MODE_SOFFLOAD, "Set protocol offload",
> + { "-k", "--show-offload", MODE_GOFFLOAD, "Get protocol offload information (deprecated)" },
> + { "-K", "--offload", MODE_SOFFLOAD, "Set protocol offload (deprecated)",
> " [ rx on|off ]\n"
> " [ tx on|off ]\n"
> " [ sg on|off ]\n"
[...]
I see no reason to deprecate the existing options.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-01-29 22:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-29 18:39 [PATCH v3 0/5] net: Unified offload configuration Michał Mirosław
2011-01-29 18:39 ` [PATCH v3 1/5] net: Introduce new feature setting ops Michał Mirosław
2011-01-29 22:24 ` Ben Hutchings
2011-02-03 13:42 ` Michał Mirosław
2011-01-29 18:39 ` [PATCH v3 2/5] net: ethtool: use ndo_fix_features for offload setting Michał Mirosław
2011-01-29 22:38 ` Ben Hutchings
2011-01-29 18:39 ` [PATCH] ethtool: implement G/SFEATURES calls Michał Mirosław
2011-01-29 22:47 ` Ben Hutchings [this message]
2011-01-29 18:39 ` [PATCH v3 4/5] net: introduce NETIF_F_RXCSUM Michał Mirosław
2011-01-29 22:45 ` Ben Hutchings
2011-01-29 18:39 ` [PATCH v3 3/5] net: use ndo_fix_features for ethtool_ops->set_flags Michał Mirosław
2011-01-29 22:44 ` Ben Hutchings
2011-02-03 13:45 ` Michał Mirosław
2011-01-29 18:39 ` [PATCH v3 5/5] loopback: convert to hw_features Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296341255.3477.67.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).