From: Sven Eckelmann <sven@narfation.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, Sven Eckelmann <sven@narfation.org>
Subject: [PATCH 3/4] batman-adv: Remove vis info element in free_info
Date: Sun, 30 Jan 2011 13:11:43 +0100 [thread overview]
Message-ID: <1296389504-11208-4-git-send-email-sven@narfation.org> (raw)
In-Reply-To: <1296389504-11208-1-git-send-email-sven@narfation.org>
The free_info function will be called when no reference to the info
object exists anymore. It must be ensured that the allocated memory
gets freed and not only the elements which are managed by the info
object.
Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
net/batman-adv/vis.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/batman-adv/vis.c b/net/batman-adv/vis.c
index 0be55be..988296c 100644
--- a/net/batman-adv/vis.c
+++ b/net/batman-adv/vis.c
@@ -64,6 +64,7 @@ static void free_info(struct kref *ref)
spin_unlock_bh(&bat_priv->vis_list_lock);
kfree_skb(info->skb_packet);
+ kfree(info);
}
/* Compare two vis packets, used by the hashing algorithm */
--
1.7.2.3
next prev parent reply other threads:[~2011-01-30 12:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-30 12:11 pull request: batman-adv 2011-01-30 Sven Eckelmann
2011-01-30 12:11 ` [PATCH 1/4] batman-adv: Fix kernel panic when fetching vis data on a vis server Sven Eckelmann
2011-01-30 12:11 ` [PATCH 2/4] batman-adv: Remove vis info on hashing errors Sven Eckelmann
2011-01-30 12:11 ` Sven Eckelmann [this message]
2011-01-30 12:11 ` [PATCH 4/4] batman-adv: Make vis info stack traversal threadsafe Sven Eckelmann
2011-01-31 6:19 ` pull request: batman-adv 2011-01-30 David Miller
-- strict thread matches above, loose matches on Subject: below --
2011-01-30 9:36 pull request: batman-adv 2011-01-29 Sven Eckelmann
2011-01-30 9:38 ` [PATCH 3/4] batman-adv: Remove vis info element in free_info Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296389504-11208-4-git-send-email-sven@narfation.org \
--to=sven@narfation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).