From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: John Fastabend <john.r.fastabend@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com, bphilips@novell.com,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next-2.6 07/16] ixgbe: DCB, remove round robin mode on 82598 devices
Date: Tue, 8 Feb 2011 04:29:18 -0800 [thread overview]
Message-ID: <1297168167-15755-8-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1297168167-15755-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: John Fastabend <john.r.fastabend@intel.com>
Remove round robin configuration code for 82598 parts it
is not settable and is always false.
If we need/want this in the future we can add it back properly.
Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Tested-by: Ross Brattain <ross.b.brattain@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ixgbe/ixgbe_dcb.h | 1 -
drivers/net/ixgbe/ixgbe_dcb_82598.c | 6 ++----
drivers/net/ixgbe/ixgbe_main.c | 1 -
3 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_dcb.h b/drivers/net/ixgbe/ixgbe_dcb.h
index 1cfe38e..d0b2450 100644
--- a/drivers/net/ixgbe/ixgbe_dcb.h
+++ b/drivers/net/ixgbe/ixgbe_dcb.h
@@ -139,7 +139,6 @@ struct ixgbe_dcb_config {
struct tc_configuration tc_config[MAX_TRAFFIC_CLASS];
u8 bw_percentage[2][MAX_BW_GROUP]; /* One each for Tx/Rx */
bool pfc_mode_enable;
- bool round_robin_enable;
enum dcb_rx_pba_cfg rx_pba_cfg;
diff --git a/drivers/net/ixgbe/ixgbe_dcb_82598.c b/drivers/net/ixgbe/ixgbe_dcb_82598.c
index 9a5e89c..19aa806 100644
--- a/drivers/net/ixgbe/ixgbe_dcb_82598.c
+++ b/drivers/net/ixgbe/ixgbe_dcb_82598.c
@@ -146,10 +146,8 @@ static s32 ixgbe_dcb_config_tx_desc_arbiter_82598(struct ixgbe_hw *hw,
/* Enable arbiter */
reg &= ~IXGBE_DPMCS_ARBDIS;
- if (!(dcb_config->round_robin_enable)) {
- /* Enable DFP and Recycle mode */
- reg |= (IXGBE_DPMCS_TDPAC | IXGBE_DPMCS_TRM);
- }
+ /* Enable DFP and Recycle mode */
+ reg |= (IXGBE_DPMCS_TDPAC | IXGBE_DPMCS_TRM);
reg |= IXGBE_DPMCS_TSOEF;
/* Configure Max TSO packet size 34KB including payload and headers */
reg |= (0x4 << IXGBE_DPMCS_MTSOS_SHIFT);
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index 602078b..ef4a517 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -5169,7 +5169,6 @@ static int __devinit ixgbe_sw_init(struct ixgbe_adapter *adapter)
adapter->dcb_cfg.bw_percentage[DCB_RX_CONFIG][0] = 100;
adapter->dcb_cfg.rx_pba_cfg = pba_equal;
adapter->dcb_cfg.pfc_mode_enable = false;
- adapter->dcb_cfg.round_robin_enable = false;
adapter->dcb_set_bitmap = 0x00;
ixgbe_copy_dcb_cfg(&adapter->dcb_cfg, &adapter->temp_dcb_cfg,
adapter->ring_feature[RING_F_DCB].indices);
--
1.7.4
next prev parent reply other threads:[~2011-02-08 12:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-08 12:29 [net-next-2.6 00/16][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2011-02-08 12:29 ` [net-next-2.6 01/16] e1000e: replace unbounded sprintf with snprintf Jeff Kirsher
2011-02-08 12:29 ` [net-next-2.6 02/16] e1000e: use correct pointer when memcpy'ing a 2-dimensional array Jeff Kirsher
2011-02-08 12:29 ` [net-next-2.6 03/16] e1000e: do not wakeup Tx queue until ready Jeff Kirsher
2011-02-08 20:21 ` David Miller
2011-02-08 20:52 ` Allan, Bruce W
2011-02-08 12:29 ` [net-next-2.6 04/16] e1000e: return appropriate errors for 'ethtool -r' Jeff Kirsher
2011-02-08 12:29 ` [net-next-2.6 05/16] igb: Enable PF side of SR-IOV support for i350 devices Jeff Kirsher
2011-02-08 12:29 ` [net-next-2.6 06/16] ixgbe: DCB, only reprogram HW if the FCoE priority is changed Jeff Kirsher
2011-02-08 12:29 ` Jeff Kirsher [this message]
2011-02-08 12:29 ` [net-next-2.6 08/16] ixgbe: DCB, abstract out dcb_config from DCB hardware configuration Jeff Kirsher
2011-02-08 12:29 ` [net-next-2.6 09/16] ixgbe: DCB, implement 802.1Qaz routines Jeff Kirsher
2011-02-08 12:29 ` [net-next-2.6 10/16] ixgbe: DCB, do not reset on CEE pg changes Jeff Kirsher
2011-02-08 12:29 ` [net-next-2.6 11/16] ixgbe: DCB, remove RESET bit it is no longer needed Jeff Kirsher
2011-02-08 12:29 ` [net-next-2.6 12/16] ixgbe: dcb, use hardware independent routines Jeff Kirsher
2011-02-08 12:29 ` [net-next-2.6 13/16] ixgbe: fix namespace issue with ixgbe_dcb_txq_to_tc Jeff Kirsher
2011-02-08 12:29 ` [net-next-2.6 14/16] ixgbe: cleanup namespace complaint by removing little used function Jeff Kirsher
2011-02-08 12:29 ` [net-next-2.6 15/16] ixgbe: cleanup ixgbe_init_mbx_params_pf namespace issue Jeff Kirsher
2011-02-08 12:29 ` [net-next-2.6 16/16] ixgbe: Adding 100MB FULL support in ethtool Jeff Kirsher
2011-02-11 15:55 ` [net-next-2.6 00/16][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297168167-15755-8-git-send-email-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=bphilips@novell.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).