From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ben Greear <greearb@candelatech.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] network: Allow af_packet to transmit +4 bytes for VLAN packets.
Date: Fri, 11 Feb 2011 19:18:56 +0100 [thread overview]
Message-ID: <1297448336.2510.9.camel@edumazet-laptop> (raw)
In-Reply-To: <4D557412.7000209@candelatech.com>
Le vendredi 11 février 2011 à 09:38 -0800, Ben Greear a écrit :
> Can you double-check that? Seems to me that in that method the out_unlock
> falls through to the out_free case. The other method is the opposite, funny
> enough...
Oops you're right, sorry.
Reading again your patch, I see you used one ETH_HLEN instead of
VLAN_HLEN in packet_snd()
next prev parent reply other threads:[~2011-02-11 18:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 21:59 [PATCH 1/2] igb: Allow extra 4 bytes on RX for vlan tags greearb
2011-02-10 21:59 ` [PATCH 2/2] network: Allow af_packet to transmit +4 bytes for VLAN packets greearb
2011-02-11 6:57 ` Eric Dumazet
2011-02-11 17:38 ` Ben Greear
2011-02-11 18:18 ` Eric Dumazet [this message]
2011-02-11 15:46 ` [PATCH 1/2] igb: Allow extra 4 bytes on RX for vlan tags Jeff Kirsher
2011-02-17 11:04 ` Jeff Kirsher
2011-02-17 17:28 ` Ben Greear
2011-07-21 0:18 ` Jesse Gross
2011-07-21 0:27 ` Ben Greear
2011-07-21 1:21 ` Jeff Kirsher
2011-07-21 6:35 ` Alexander Duyck
2011-07-21 21:44 ` Jesse Gross
2011-08-25 18:51 ` Ben Greear
2011-08-25 23:31 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297448336.2510.9.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox