Netdev List
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Andy Gospodarek <andy@greyhouse.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"Skidmore, Donald C" <donald.c.skidmore@intel.com>,
	"Duyck, Alexander H" <alexander.h.duyck@intel.com>,
	"Rose, Gregory V" <gregory.v.rose@intel.com>
Subject: Re: [PATCH net-2.6] ixgbe: fix panic due to uninitialied pointer
Date: Fri, 11 Feb 2011 14:41:21 -0800	[thread overview]
Message-ID: <1297464081.3544.72.camel@jtkirshe-MOBL1> (raw)
In-Reply-To: <1297460747-31896-1-git-send-email-andy@greyhouse.net>

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

On Fri, 2011-02-11 at 13:45 -0800, Andy Gospodarek wrote:
> Systems containing an 82599EB and running a backported driver from
> upstream were panicing on boot.  It turns out hw->mac.ops.setup_sfp is
> only set for 82599, so one should check to be sure that pointer is set
> before continuing in ixgbe_sfp_config_module_task.  I verified by
> inspection that the upstream driver has the same issue and also added
> a
> check before the call in ixgbe_sfp_link_config.
> 
> Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
> ---
>  drivers/net/ixgbe/ixgbe_main.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-) 

Thanks Andy!  Have added the patch (with fixed subject) to my ixgbe
queue of patches.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

  parent reply	other threads:[~2011-02-11 22:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-11 21:45 [PATCH net-2.6] ixgbe: fix panic due to uninitialied pointer Andy Gospodarek
2011-02-11 21:56 ` [PATCH net-2.6] ixgbe: fix panic due to uninitialized pointer Andy Gospodarek
2011-02-11 22:41 ` Jeff Kirsher [this message]
2011-02-11 22:47 ` [PATCH net-2.6] ixgbe: fix panic due to uninitialied pointer Skidmore, Donald C

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1297464081.3544.72.camel@jtkirshe-MOBL1 \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=andy@greyhouse.net \
    --cc=donald.c.skidmore@intel.com \
    --cc=gregory.v.rose@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox