From: Eric Dumazet <eric.dumazet@gmail.com>
To: Andreas Fenkart <afenkart@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] ARC VMAC ethernet driver.
Date: Tue, 15 Feb 2011 11:02:29 +0100 [thread overview]
Message-ID: <1297764149.3201.4.camel@edumazet-laptop> (raw)
In-Reply-To: <1297762288-9263-1-git-send-email-afenkart@gmail.com>
Le mardi 15 février 2011 à 10:31 +0100, Andreas Fenkart a écrit :
> Signed-off-by: Andreas Fenkart <afenkart@gmail.com>
> + processed++;
> + skb->dev = dev;
eth_type_trans() already sets "skb->dev = dev;"
> + skb->protocol = eth_type_trans(skb, dev);
> + ap->stats.rx_packets++;
Hmm, why dont you use dev->stats internal structure ? No need to
maintain a shadow in ap->stats.
> + ap->stats.rx_bytes += skb->len;
> + dev->last_rx = jiffies;
/* last_rx = jiffies; not needed anymore */
> + netif_rx(skb);
A NAPI driver should use netif_receive_skb(), not netif_rx()
next prev parent reply other threads:[~2011-02-15 10:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 7:54 [PATCH 0/1] ARC vmac ethernet driver Andreas Fenkart
2010-10-15 7:54 ` [PATCH 1/1] " Andreas Fenkart
2010-10-19 13:53 ` David Miller
2010-12-02 12:39 ` Andreas Fenkart
2010-12-02 12:46 ` [PATCH 1/1] arcvmac submit #4 Andreas Fenkart
2010-12-02 13:10 ` Andreas Fenkart
2010-12-02 13:21 ` [PATCH 1/1] arcvmac submit #4a Andreas Fenkart
2010-12-08 17:00 ` David Miller
2011-02-15 9:31 ` [PATCH 1/1] ARC VMAC ethernet driver Andreas Fenkart
2011-02-15 10:02 ` Eric Dumazet [this message]
2011-02-17 9:26 ` Andreas Fenkart
2011-02-17 9:31 ` Andreas Fenkart
2011-02-17 10:13 ` Eric Dumazet
-- strict thread matches above, loose matches on Subject: below --
2010-02-22 0:21 [PATCH 1/1] ARC vmac " Andreas Fenkart
2010-02-22 23:40 ` David Miller
2010-03-01 23:18 ` [PATCH 0/5] " Andreas Fenkart
2010-03-01 23:18 ` [PATCH 1/1] " Andreas Fenkart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297764149.3201.4.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=afenkart@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox