From: Eric Dumazet <eric.dumazet@gmail.com>
To: Stanislaw Gruszka <stf_xl@wp.pl>
Cc: netdev@vger.kernel.org, Octavian Purdila <opurdila@ixiacom.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] net: fix unreg list corruption in dev_deactivate()
Date: Sun, 20 Feb 2011 13:11:30 +0100 [thread overview]
Message-ID: <1298203890.8559.54.camel@edumazet-laptop> (raw)
In-Reply-To: <20110220113429.GA27047@localhost.localdomain>
Le dimanche 20 février 2011 à 12:34 +0100, Stanislaw Gruszka a écrit :
> Patch fix issue introduced by 443457242beb6716b43db4d62fe148eab5515505
> "net: factorize sync-rcu call in unregister_netdevice_many". It manifest
> on my system by following warning when removing usb wireless device.
>
> [ 3539.368139] WARNING: at lib/list_debug.c:53 __list_del_entry+0x62/0x71()
> [ 3539.368149] list_del corruption. prev->next should be f035e05c, but was f1ce670c
> [ 3539.368242] Call Trace:
> [ 3539.368254] [<c04393d7>] ? warn_slowpath_common+0x6a/0x7f
> [ 3539.368262] [<c05bd062>] ? __list_del_entry+0x62/0x71
> [ 3539.368269] [<c043945f>] ? warn_slowpath_fmt+0x2b/0x2f
> [ 3539.368276] [<c05bd062>] ? __list_del_entry+0x62/0x71
> [ 3539.368286] [<c06f6d06>] ? unregister_netdevice_queue+0x41/0x6e
> [ 3539.368322] [<fa1ee998>] ? ieee80211_remove_interfaces+0x7b/0x9a [mac80211]
> [ 3539.368348] [<fa1e208a>] ? ieee80211_unregister_hw+0x48/0xf9 [mac80211]
> [ 3539.368363] [<fa223903>] ? rt2x00lib_remove_dev+0x76/0xd1 [rt2x00lib]
> [ 3539.368372] [<fa2770b1>] ? rt2x00usb_disconnect+0x29/0x8c [rt2x00usb]
> [ 3539.368382] [<c069ef8c>] ? usb_unbind_interface+0x48/0xfd
>
> I'm no longer seeing warning with patch applied.
>
> Signed-off-by: Stanislaw Gruszka <stf_xl@wp.pl>
> ---
> I did not try review related code. I think someone who understand it,
> should audit it carefully to exclude similar issues. Adding
> dev->unreg_list to various local list, when device will not gonna be
> destroyed looks really fishy.
>
> diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
> index 34dc598..1bc6980 100644
> --- a/net/sched/sch_generic.c
> +++ b/net/sched/sch_generic.c
> @@ -839,6 +839,7 @@ void dev_deactivate(struct net_device *dev)
>
> list_add(&dev->unreg_list, &single);
> dev_deactivate_many(&single);
> + list_del(&single);
> }
>
> static void dev_init_scheduler_queue(struct net_device *dev,
Hmm, you should read Eric B patch, he already addressed this problem a
few hours ago.
A full audit _is_ needed.
https://lkml.org/lkml/2011/2/20/4
next prev parent reply other threads:[~2011-02-20 12:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-20 11:34 [PATCH] net: fix unreg list corruption in dev_deactivate() Stanislaw Gruszka
2011-02-20 12:11 ` Eric Dumazet [this message]
2011-02-20 12:44 ` Stanislaw Gruszka
2011-02-20 19:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298203890.8559.54.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=opurdila@ixiacom.com \
--cc=stf_xl@wp.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox