public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jon Zhou <Jon.Zhou@jdsu.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: why all packets have same queue no when rps enabled?
Date: Tue, 22 Feb 2011 06:41:10 +0100	[thread overview]
Message-ID: <1298353270.3360.1.camel@edumazet-laptop> (raw)
In-Reply-To: <4A6A2125329CFD4D8CC40C9E8ABCAB9F24D3DE6D0C@MILEXCH2.ds.jdsu.net>

Le lundi 21 février 2011 à 20:07 -0800, Jon Zhou a écrit :
> Hi
> 
> I expect each incoming packet will have a different queue no. when I enabled RPS on kernel 2.6.36.4
> 
> cat /sys/class/net/eth4/queues/rx-0/rps_cpus
> 00000000,000000ff
> 
> CPU0       CPU1       CPU2       CPU3       CPU4       CPU5       CPU6       CPU7       CPU8       CPU9       CPU10      CPU11      CPU12      CPU13      CPU14      CPU15      CPU16
>       CPU17      CPU18      CPU19      CPU20      CPU21      CPU22      CPU23      CPU24      CPU25      CPU26      CPU27      CPU28      CPU29      CPU30      CPU31
>      HI:          0          0          0          0          0          0          0          0          0          0          0          0          0          0          0          0          0
>          0          0          0          0          0          0          0          0          0          0          0          0          0          0          0
>    TIMER:    6027512     710165    2623243     542768     427807     217424     192940     217043          0          0          0          0          0          0          0          0          0
>          0          0          0          0          0          0          0          0          0          0          0          0          0          0          0
>   NET_TX:    1365741         59     750957          0        171          0          3          0          0          0          0          0          0          0          0          0          0
>          0          0          0          0          0          0          0          0          0          0          0          0          0          0          0
>   NET_RX:   40465750   11140803    8545859   14417762    8913471   12298691   14216845    3348431   < ---- indeed spread across cpus
> 
> 
> I manually disable RSS on the intel X520 multiqueue supported NIC.
> Cat /proc/interrupts
> 
>   87:   21348294          0          0          0          0          0          0          0   PCI-MSI-edge      eth4-rx-0
>   88:      38394          0          0          0          0          0          0          0   PCI-MSI-edge      eth4-tx-0
> 
> 
> 
> When I tried the below program to filter packet by queue no.I got these results:
> 
> struct sock_filter BPF_code[]= {     
>     { 0x28,0,0,SKF_AD_OFF+SKF_AD_QUEUE},
>     { 0x15, 0, 1, 0x00000001 },
>     { 0x6, 0, 0, 0x0000ffff },
>     { 0x6, 0, 0, 0x00000000 }
>   };
> 
>   struct sock_fprog Filter; 
>     
>   Filter.len = 4;//15;
>   Filter.filter = BPF_code;
>   
>   if ( (sock=socket(PF_PACKET, SOCK_RAW, htons(ETH_P_IP)))<0) {
>     perror("socket");
>     exit(1);
>   }
> 
>   /* Set the network card in promiscuos mode */
>   strncpy(ethreq.ifr_name,"eth4",IFNAMSIZ);
>   if (ioctl(sock,SIOCGIFFLAGS,&ethreq)==-1) {
>     perror("ioctl");
>     close(sock);
>     exit(1);
>   }
>   ethreq.ifr_flags|=IFF_PROMISC;
>   if (ioctl(sock,SIOCSIFFLAGS,&ethreq)==-1) {
>     perror("ioctl");
>     close(sock);
>     exit(1);
>   }
> 
>   /* Attach the filter to the socket */
>   if(setsockopt(sock, SOL_SOCKET, SO_ATTACH_FILTER,&Filter, sizeof(Filter))<0){
>     perror("setsockopt");
>     close(sock);
>     exit(1);
>   }
>   static int count = 0;
>   while (1) {
>     printf("#%d----------\n",count++);
>     n = recvfrom(sock,buffer,2048,0,NULL,NULL);
>     printf("%d bytes read\n",n);
> ...
> }
> 
> 
> Looks almost all packets fall at same queue?
> Will RPS allocate queue no for each packet? and what hash algorithm rps used? (is it Toeplitz hash algorithm?)
> 

I believe you are mistaken.

RPS is not there to spread load on _all_ cpus, but to use a hash
function so that all packets of a given flow are directed to a given
cpu.

If you receive 1.000.000 packets of the same flow, they all are
delivered to one CPU.




  reply	other threads:[~2011-02-22  5:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-22  4:07 why all packets have same queue no when rps enabled? Jon Zhou
2011-02-22  5:41 ` Eric Dumazet [this message]
2011-02-22  5:56   ` Jon Zhou
2011-02-22  6:13     ` Eric Dumazet
2011-02-22 12:45 ` Ben Hutchings
2011-02-22 13:01   ` Eric Dumazet
2011-02-22 13:09     ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1298353270.3360.1.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=Jon.Zhou@jdsu.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox