From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: "prasanna.panchamukhi@riverbed.com" <prasanna.panchamukhi@riverbed.com>
Cc: "Allan, Bruce W" <bruce.w.allan@intel.com>,
"Pieper, Jeffrey E" <jeffrey.e.pieper@intel.com>,
"e1000-devel@lists.sourceforge.net"
<e1000-devel@lists.sourceforge.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] e1000: power off PHY after reset when interface is down
Date: Wed, 23 Feb 2011 16:02:45 -0800 [thread overview]
Message-ID: <1298505765.25453.17.camel@jtkirshe-linux> (raw)
In-Reply-To: <1298424313-9840-1-git-send-email-prasanna.panchamukhi@riverbed.com>
[-- Attachment #1: Type: text/plain, Size: 988 bytes --]
On Tue, 2011-02-22 at 17:25 -0800, prasanna.panchamukhi@riverbed.com
wrote:
> From: Prasanna S. Panchamukhi <prasanna.panchamukhi@riverbed.com>
>
> Some Phys supported by the e1000 driver do not remain powered off
> across
> a reset of the device when the interface is down, e.g. on 82546.
> This patch powers down (only when WoL is disabled) the PHY after reset
> if
> the interface is down and ethtool diagnostics are not currently
> running.
>
> Similar problem was see on 82571 controller and was fixed in e1000e
> driver
> by Bruce Allan.
> Please refer commit 31dbe5b4ac6fca72dec946e4d0fa7f0913f1d9b1 for
> details.
>
> Signed-off-by: Prasanna S. Panchamukhi
> <prasanna.panchamukhi@riverbed.com>
> ---
> drivers/net/e1000/e1000_ethtool.c | 27 +++++++++++++++++++--------
> drivers/net/e1000/e1000_main.c | 7 +++++++
> 2 files changed, 26 insertions(+), 8 deletions(-)
Thanks Prasanna! I have added the patch to my queue of e1000 patches.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2011-02-24 0:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 1:25 [PATCH] e1000: power off PHY after reset when interface is down prasanna.panchamukhi
2011-02-24 0:02 ` Jeff Kirsher [this message]
2011-03-04 8:19 ` Jeff Kirsher
2011-03-04 18:03 ` Prasanna Panchamukhi
2011-03-04 22:41 ` Prasanna Panchamukhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298505765.25453.17.camel@jtkirshe-linux \
--to=jeffrey.t.kirsher@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.e.pieper@intel.com \
--cc=netdev@vger.kernel.org \
--cc=prasanna.panchamukhi@riverbed.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).