Re: [PATCH] net_sched: long word align struct qdisc_skb_cb data

David Miller
2011-02-23T22:16:46Z

From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 23 Feb 2011 09:30:01 -0800

> On Wed, 23 Feb 2011 18:05:07 +0100
> Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
>> Le mercredi 23 février 2011 à 17:24 +0100, Patrick McHardy a écrit :
>> > Am 23.02.2011 16:14, schrieb Eric Dumazet:
>> > > diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
>> > > index 16626a0..f40d32e 100644
>> > > --- a/include/net/sch_generic.h
>> > > +++ b/include/net/sch_generic.h
>> > > @@ -218,6 +218,7 @@ struct tcf_proto {
>> > >
>> > > struct qdisc_skb_cb {
>> > > unsigned int pkt_len;
>> > > + unsigned int sfb_classid;
>> > > char data[];
>> > > };
>> >
>> > This could be moved into a SFB specific cb, similar to what netem
>> > does.
>>
>> Hmm... well... I want to be sure no other sch will destroy my values.
>>
>> netem seems buggy then.
>>
>> Probably following patch is needed ?
>
> Yes, it was long word aligned when netem was written but
> we seem to have bit creep.

Applied to net-2.6, thanks!