From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Jesse Gross <jesse@nicira.com>,
"Allan, Bruce W" <bruce.w.allan@intel.com>
Cc: Jan Niehusmann <jan@gondor.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Tantilov, Emil S" <emil.s.tantilov@intel.com>
Subject: Re: TX VLAN acceleration on bridges broken in 2.6.37?
Date: Fri, 25 Feb 2011 17:22:15 -0800 [thread overview]
Message-ID: <1298683335.2643.165.camel@jtkirshe-MOBL1> (raw)
In-Reply-To: <AANLkTikVvjsaG94-gtauvTLjH_RW5fmva8+N7Lk-ryQ0@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1610 bytes --]
On Fri, 2011-02-25 at 17:16 -0800, Jesse Gross wrote:
> On Fri, Feb 25, 2011 at 4:19 PM, Jan Niehusmann <jan@gondor.com> wrote:
> > On Fri, Feb 25, 2011 at 02:53:21PM -0800, Jesse Gross wrote:
> >> is specific to the e1000e driver. I know that some other Intel NICs
> >> require vlan stripping on receive to be enabled for vlan insertion on
> >> transmit to work. Since this driver has not been converted over to
> >> use the new vlan model yet, it only enables these things if a vlan is
> >> directly configured on it. To confirm this can you try a few things:
> >
> > My observations confirm your theory:
>
> OK, thanks for confirming. The right solution is convert the driver
> over to the new vlan model. I don't know how soon I might get to
> this, maybe it's something that the Intel guys can take a look at?
I have made sure that Bruce is aware of the issue.
We will see what we can do to get some patches created and under
testing.
>
> > - indeed, -e is necessary to show the vlan tags. So my prior observation
> > regarding tag visibility in tcpdump was wrong. The packets are still
> > have a vlan tag in the non-working case.
> >
> > (What actually is affected by the txvlan flag is the ability to filter
> > for vlan tags with tcpdump. so 'tcpdump -e -i eth0' shows the packets,
> > 'tcpdump -e -i eth0 vlan' only shows them with txvlan off. However,
> > filtering for the vlan tag also doesn't work with the vlan interface
> > on eth0.1, while the tagging actually works, as verified above.)
>
> Good to know, though that's a separate issue.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
prev parent reply other threads:[~2011-02-26 1:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 23:29 TX VLAN acceleration on bridges broken in 2.6.37? Jan Niehusmann
2011-02-23 1:32 ` Jesse Gross
2011-02-25 22:53 ` Jesse Gross
2011-02-26 0:19 ` Jan Niehusmann
2011-02-26 1:16 ` Jesse Gross
2011-02-26 1:22 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298683335.2643.165.camel@jtkirshe-MOBL1 \
--to=jeffrey.t.kirsher@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=emil.s.tantilov@intel.com \
--cc=jan@gondor.com \
--cc=jesse@nicira.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).