From: Ben Hutchings <bhutchings@solarflare.com>
To: David Miller <davem@davemloft.net>
Cc: alexander.h.duyck@intel.com, santwona.behera@sun.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] ethtool: Compat handling for struct ethtool_rxnfc
Date: Mon, 28 Feb 2011 19:12:50 +0000 [thread overview]
Message-ID: <1298920370.2569.15.camel@bwh-desktop> (raw)
In-Reply-To: <20110228.110655.71121452.davem@davemloft.net>
On Mon, 2011-02-28 at 11:06 -0800, David Miller wrote:
> From: Ben Hutchings <bhutchings@solarflare.com>
> Date: Mon, 28 Feb 2011 18:22:26 +0000
>
> > This structure was accidentally defined such that its layout can
> > differ between 32-bit and 64-bit processes. Add compat structure
> > definitions and functions to copy from/to user-space with the
> > necessary adjustments.
> >
> > Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
>
> Please implement this via the proper contextual compat ioctl handling
> in net/socket.c
>
> Using is_compat_task() is heavily discouraged.
This is going to be even more horrible. But I'll try it.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-02-28 19:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 18:22 [PATCH net-next-2.6] ethtool: Compat handling for struct ethtool_rxnfc Ben Hutchings
2011-02-28 19:06 ` David Miller
2011-02-28 19:12 ` Ben Hutchings [this message]
2011-04-11 17:10 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298920370.2569.15.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=santwona.behera@sun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox