Re: [PATCH] sched: QFQ - quick fair queue scheduler (v2)

Fabio Checconi
2011-03-03T15:06:01Z

> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Thu, Mar 03, 2011 11:40:20AM +0100
>
> Le jeudi 03 mars 2011 à 09:27 +0100, Eric Dumazet a écrit :
>
> > I am going to test an updated version, thanks for all these hints !
> >
>
> Same problem in qfq_qlen_notify()
>
> Should use :
>
> struct qfq_sched *q = qdisc_priv(sch);
>

Absolutely right, as you're right about qfq_drop(). I'll be able to take
a look when I'm back from work this evening.

A question on the data below:

> After a stress (and no more trafic) I still have some packets in
> backlog:
>
> (8 packets here)
>
...
> class qfq 11:10 root weight 1600 maxpkt 2048
> Sent 200 bytes 1 pkt (dropped 18181, overlimits 0 requeues 0)
> rate 0bit 0pps backlog 200b 0p requeues 0

Any other reason, apart from a bug in QFQ, why there could be 200b and
0p of backlog? A packet count out of sync could explain also why you
were experiencing problems with pfifo in presence of drops...

Thanks for your help, fixes, and testing,
fabio