Re: [PATCH] sched: QFQ - quick fair queue scheduler (v3)

Stephen Hemminger
2011-03-04T00:03:47Z

On Thu, 03 Mar 2011 23:28:53 +0100
Eric Dumazet <eric.dumazet@gmail.com> wrote:

> Here there is the problem of *pp = cl->next (possibly NULL)
>
> maybe use
>
> for (pp = &grp->slots[j]; (cl = *pp) != NULL;) {
> if (cl->qdisc->q.len)
> qfq_deactivate_class(...);
> else
> pp = &cl->next;
> }
>

I think changing slots from open coded linked list
to double linked list (list_for_each) would be clearer
and avoid these kind of bugs. That is what DRR does.

--