* [PATCH] ethtool: remove mask for Auto in advertise section
@ 2011-03-05 7:27 Jeff Kirsher
2011-03-23 15:56 ` Ben Hutchings
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Kirsher @ 2011-03-05 7:27 UTC (permalink / raw)
To: bhutchings; +Cc: Emil Tantilov, netdev, Jeff Kirsher
From: Emil Tantilov <emil.s.tantilov@intel.com>
The mask for Auto in the advertise section is incorrect for any interface
that supports speeds > 1000Mbps. Since the description already states that
the mask can be a combination of the supported values it's probably better
to just remove it. 'Auto' was misleading anyway.
Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
Tested-by: Stephen Ko <stephen.s.ko@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
ethtool.8.in | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/ethtool.8.in b/ethtool.8.in
index 0ee91a0..d7bcc51 100644
--- a/ethtool.8.in
+++ b/ethtool.8.in
@@ -516,8 +516,6 @@ a hexadecimal value using one or a combination of the following values:
.BR "0x8000" " 2500 Full" "(not supported by IEEE standards)"
.TP 3
.BR "0x1000" " 10000 Full"
-.TP 3
-.BR "0x03F" " Auto"
.PD
.RE
.TP
--
1.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ethtool: remove mask for Auto in advertise section
2011-03-05 7:27 [PATCH] ethtool: remove mask for Auto in advertise section Jeff Kirsher
@ 2011-03-23 15:56 ` Ben Hutchings
0 siblings, 0 replies; 2+ messages in thread
From: Ben Hutchings @ 2011-03-23 15:56 UTC (permalink / raw)
To: Jeff Kirsher; +Cc: Emil Tantilov, netdev
On Fri, 2011-03-04 at 23:27 -0800, Jeff Kirsher wrote:
> From: Emil Tantilov <emil.s.tantilov@intel.com>
>
> The mask for Auto in the advertise section is incorrect for any interface
> that supports speeds > 1000Mbps. Since the description already states that
> the mask can be a combination of the supported values it's probably better
> to just remove it. 'Auto' was misleading anyway.
[...]
Applied.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-23 15:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-05 7:27 [PATCH] ethtool: remove mask for Auto in advertise section Jeff Kirsher
2011-03-23 15:56 ` Ben Hutchings
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).