[PATCH] ixgbe: fix for 82599 erratum on Header Splitting

[PATCH] ixgbe: fix for 82599 erratum on Header Splitting

[Jeff Kirsher]

From: Don Skidmore <donald.c.skidmore@intel.com>

We have found a hardware erratum on 82599 hardware that can lead to
unpredictable behavior when Header Splitting mode is enabled.  So
we are no longer enabling this feature on affected hardware.

Signed-off-by: Don Skidmore <donald.c.skidmore@intel.com>
Tested-by: Stephen Ko <stephen.s.ko@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ixgbe/ixgbe_main.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index a873c5d..67d1d97 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -2131,6 +2131,10 @@ static void ixgbe_configure_rx(struct ixgbe_adapter *adapter)
 	/* Decide whether to use packet split mode or not */
 	adapter->flags |= IXGBE_FLAG_RX_PS_ENABLED;
 
+	/* Disable packet split due to 82599 erratum #45 */
+	if (hw->mac.type == ixgbe_mac_82599EB)
+		adapter->flags &= ~IXGBE_FLAG_RX_PS_ENABLED;
+
 	/* Set the RX buffer length according to the mode */
 	if (adapter->flags & IXGBE_FLAG_RX_PS_ENABLED) {
 		rx_buf_len = IXGBE_RX_HDR_SIZE;
-- 
1.7.4

Re: [PATCH] ixgbe: fix for 82599 erratum on Header Splitting

[Greg KH]

On Fri, Mar 04, 2011 at 11:06:07PM -0800, Jeff Kirsher wrote:
> From: Don Skidmore <donald.c.skidmore@intel.com>
> 
> We have found a hardware erratum on 82599 hardware that can lead to
> unpredictable behavior when Header Splitting mode is enabled.  So
> we are no longer enabling this feature on affected hardware.
> 
> Signed-off-by: Don Skidmore <donald.c.skidmore@intel.com>
> Tested-by: Stephen Ko <stephen.s.ko@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> ---
>  drivers/net/ixgbe/ixgbe_main.c |    4 ++++

I'm confused, why did you just send this patch to me?

What am I supposed to do with it?

greg k-h

Re: [PATCH] ixgbe: fix for 82599 erratum on Header Splitting

[Jeff Kirsher]

[-- Attachment #1: Type: text/plain, Size: 963 bytes --]

On Fri, 2011-03-04 at 23:44 -0800, Greg KH wrote:
> On Fri, Mar 04, 2011 at 11:06:07PM -0800, Jeff Kirsher wrote:
> > From: Don Skidmore <donald.c.skidmore@intel.com>
> > 
> > We have found a hardware erratum on 82599 hardware that can lead to
> > unpredictable behavior when Header Splitting mode is enabled.  So
> > we are no longer enabling this feature on affected hardware.
> > 
> > Signed-off-by: Don Skidmore <donald.c.skidmore@intel.com>
> > Tested-by: Stephen Ko <stephen.s.ko@intel.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> > ---
> >  drivers/net/ixgbe/ixgbe_main.c |    4 ++++
> 
> I'm confused, why did you just send this patch to me?
> 
> What am I supposed to do with it?
> 
> greg k-h

This is the fix for ixgbe (that Ben and others pointed out) which has
been accepted into Linus's tree which did not apply to stable-2.6.32
tree.  This is the updated patch that apply's to the stable-2.6.32 tree.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

Re: [PATCH] ixgbe: fix for 82599 erratum on Header Splitting

[Greg KH]

On Fri, Mar 04, 2011 at 11:51:07PM -0800, Jeff Kirsher wrote:
> On Fri, 2011-03-04 at 23:44 -0800, Greg KH wrote:
> > On Fri, Mar 04, 2011 at 11:06:07PM -0800, Jeff Kirsher wrote:
> > > From: Don Skidmore <donald.c.skidmore@intel.com>
> > > 
> > > We have found a hardware erratum on 82599 hardware that can lead to
> > > unpredictable behavior when Header Splitting mode is enabled.  So
> > > we are no longer enabling this feature on affected hardware.
> > > 
> > > Signed-off-by: Don Skidmore <donald.c.skidmore@intel.com>
> > > Tested-by: Stephen Ko <stephen.s.ko@intel.com>
> > > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> > > ---
> > >  drivers/net/ixgbe/ixgbe_main.c |    4 ++++
> > 
> > I'm confused, why did you just send this patch to me?
> > 
> > What am I supposed to do with it?
> > 
> > greg k-h
> 
> This is the fix for ixgbe (that Ben and others pointed out) which has
> been accepted into Linus's tree which did not apply to stable-2.6.32
> tree.  This is the updated patch that apply's to the stable-2.6.32 tree.

How nice, but why didn't you say so in the first place?  Am I really
supposed to remember the hundreds of stable patches I handle every week?

Oh, I need the git commit id of it as well, care to resend this with
that and the proper "please apply this for the .32 longterm tree"
message so I can?

If so, I'll queue it up for the after-next .32-longterm release.

thanks,

greg k-h

Re: [PATCH] ixgbe: fix for 82599 erratum on Header Splitting

[Jeff Kirsher]

[-- Attachment #1: Type: text/plain, Size: 2043 bytes --]

On Fri, 2011-03-04 at 23:59 -0800, Greg KH wrote:
> On Fri, Mar 04, 2011 at 11:51:07PM -0800, Jeff Kirsher wrote:
> > On Fri, 2011-03-04 at 23:44 -0800, Greg KH wrote:
> > > On Fri, Mar 04, 2011 at 11:06:07PM -0800, Jeff Kirsher wrote:
> > > > From: Don Skidmore <donald.c.skidmore@intel.com>
> > > > 
> > > > We have found a hardware erratum on 82599 hardware that can lead to
> > > > unpredictable behavior when Header Splitting mode is enabled.  So
> > > > we are no longer enabling this feature on affected hardware.
> > > > 
> > > > Signed-off-by: Don Skidmore <donald.c.skidmore@intel.com>
> > > > Tested-by: Stephen Ko <stephen.s.ko@intel.com>
> > > > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> > > > ---
> > > >  drivers/net/ixgbe/ixgbe_main.c |    4 ++++
> > > 
> > > I'm confused, why did you just send this patch to me?
> > > 
> > > What am I supposed to do with it?
> > > 
> > > greg k-h
> > 
> > This is the fix for ixgbe (that Ben and others pointed out) which has
> > been accepted into Linus's tree which did not apply to stable-2.6.32
> > tree.  This is the updated patch that apply's to the stable-2.6.32 tree.
> 
> How nice, but why didn't you say so in the first place?  Am I really
> supposed to remember the hundreds of stable patches I handle every week?

Sorry, I sent you/stable an email saying that I would send you an
updated patch that would apply to stable-2.6.32.  I know you deal with a
number of patches, so I apologize.

> 
> Oh, I need the git commit id of it as well, care to resend this with
> that and the proper "please apply this for the .32 longterm tree"
> message so I can?
> 

Heres is the commit info:
commit a124339ad28389093ed15eca990d39c51c5736cc
Author: Don Skidmore <donald.c.skidmore@intel.com>
Date:   Tue Jan 18 22:53:47 2011 +0000


> If so, I'll queue it up for the after-next .32-longterm release.
> 

I can resend the entire patch submission again, with the info provided,
if necessary.

> thanks,
> 
> greg k-h



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]