* [stable-2.6.32.y] ixgbe: fix for 82599 erratum on Header Splitting
@ 2011-03-05 23:14 Jeff Kirsher
2011-03-08 19:48 ` [stable] " Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Kirsher @ 2011-03-05 23:14 UTC (permalink / raw)
To: gregkh; +Cc: Don Skidmore, stable, netdev, Jeff Kirsher
From: Don Skidmore <donald.c.skidmore@intel.com>
We have found a hardware erratum on 82599 hardware that can lead to
unpredictable behavior when Header Splitting mode is enabled. So
we are no longer enabling this feature on affected hardware.
This is an updated version of the following commit which applies to the stable
linux-2.6.32.y tree:
commit a124339ad28389093ed15eca990d39c51c5736cc
Author: Don Skidmore <donald.c.skidmore@intel.com>
Date: Tue Jan 18 22:53:47 2011 +0000
ixgbe: fix for 82599 erratum on Header Splitting
Please aaply this for the .32 longterm tree.
Signed-off-by: Don Skidmore <donald.c.skidmore@intel.com>
Tested-by: Stephen Ko <stephen.s.ko@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ixgbe/ixgbe_main.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index a873c5d..67d1d97 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -2131,6 +2131,10 @@ static void ixgbe_configure_rx(struct ixgbe_adapter *adapter)
/* Decide whether to use packet split mode or not */
adapter->flags |= IXGBE_FLAG_RX_PS_ENABLED;
+ /* Disable packet split due to 82599 erratum #45 */
+ if (hw->mac.type == ixgbe_mac_82599EB)
+ adapter->flags &= ~IXGBE_FLAG_RX_PS_ENABLED;
+
/* Set the RX buffer length according to the mode */
if (adapter->flags & IXGBE_FLAG_RX_PS_ENABLED) {
rx_buf_len = IXGBE_RX_HDR_SIZE;
--
1.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [stable] [stable-2.6.32.y] ixgbe: fix for 82599 erratum on Header Splitting
2011-03-05 23:14 [stable-2.6.32.y] ixgbe: fix for 82599 erratum on Header Splitting Jeff Kirsher
@ 2011-03-08 19:48 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2011-03-08 19:48 UTC (permalink / raw)
To: Jeff Kirsher; +Cc: gregkh, Don Skidmore, stable, netdev
On Sat, Mar 05, 2011 at 03:14:50PM -0800, Jeff Kirsher wrote:
> From: Don Skidmore <donald.c.skidmore@intel.com>
>
> We have found a hardware erratum on 82599 hardware that can lead to
> unpredictable behavior when Header Splitting mode is enabled. So
> we are no longer enabling this feature on affected hardware.
>
> This is an updated version of the following commit which applies to the stable
> linux-2.6.32.y tree:
Applied, thanks.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-08 19:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-05 23:14 [stable-2.6.32.y] ixgbe: fix for 82599 erratum on Header Splitting Jeff Kirsher
2011-03-08 19:48 ` [stable] " Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).