netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Emil Tantilov <emil.s.tantilov@intel.com>,
	netdev@vger.kernel.org, gospo@redhat.com, bphilips@novell.com,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next-2.6 12/14] ixgbe: improve logic in ixgbe_init_mbx_params_pf
Date: Mon,  7 Mar 2011 18:25:06 -0800	[thread overview]
Message-ID: <1299551108-23663-13-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1299551108-23663-1-git-send-email-jeffrey.t.kirsher@intel.com>

From: Emil Tantilov <emil.s.tantilov@intel.com>

Use if/then instead of an all-inclusive case statement.

Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
Tested-by: Stephen Ko <stephen.s.ko@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ixgbe/ixgbe_mbx.c |   27 ++++++++++++---------------
 1 files changed, 12 insertions(+), 15 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_mbx.c b/drivers/net/ixgbe/ixgbe_mbx.c
index 2acacfa..3cf8aec 100644
--- a/drivers/net/ixgbe/ixgbe_mbx.c
+++ b/drivers/net/ixgbe/ixgbe_mbx.c
@@ -448,23 +448,20 @@ void ixgbe_init_mbx_params_pf(struct ixgbe_hw *hw)
 {
 	struct ixgbe_mbx_info *mbx = &hw->mbx;
 
-	switch (hw->mac.type) {
-	case ixgbe_mac_82599EB:
-	case ixgbe_mac_X540:
-		mbx->timeout = 0;
-		mbx->usec_delay = 0;
+	if (hw->mac.type != ixgbe_mac_82599EB &&
+	    hw->mac.type != ixgbe_mac_X540)
+		return;
 
-		mbx->size = IXGBE_VFMAILBOX_SIZE;
+	mbx->timeout = 0;
+	mbx->udelay = 0;
 
-		mbx->stats.msgs_tx = 0;
-		mbx->stats.msgs_rx = 0;
-		mbx->stats.reqs = 0;
-		mbx->stats.acks = 0;
-		mbx->stats.rsts = 0;
-		break;
-	default:
-		break;
-	}
+	mbx->stats.msgs_tx = 0;
+	mbx->stats.msgs_rx = 0;
+	mbx->stats.reqs = 0;
+	mbx->stats.acks = 0;
+	mbx->stats.rsts = 0;
+
+	mbx->size = IXGBE_VFMAILBOX_SIZE;
 }
 #endif /* CONFIG_PCI_IOV */
 
-- 
1.7.4


  parent reply	other threads:[~2011-03-08  2:26 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-08  2:24 [net-next-2.6 00/14][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2011-03-08  2:24 ` [net-next-2.6 01/14] e1000e: fix build issue due to undefined reference to crc32_le Jeff Kirsher
2011-03-08  2:24 ` [net-next-2.6 02/14] igb: Add stats output for OS2BMC feature on i350 devices Jeff Kirsher
2011-03-08  2:24 ` [net-next-2.6 03/14] ixgbe: fix missing function pointer conversion Jeff Kirsher
2011-03-08  2:24 ` [net-next-2.6 04/14] net: add ndo_fcoe_ddp_target() to support FCoE DDP in target mode Jeff Kirsher
2011-03-08  2:43   ` Ben Hutchings
2011-03-08  2:54     ` Zou, Yi
2011-03-08  2:24 ` [net-next-2.6 05/14] vlan: add support to ndo_fcoe_ddp_target() Jeff Kirsher
2011-03-08  2:44   ` Ben Hutchings
2011-03-08  2:51     ` Zou, Yi
2011-03-08  2:25 ` [net-next-2.6 06/14] ixgbe: add support to FCoE DDP in target mode Jeff Kirsher
2011-03-08  2:25 ` [net-next-2.6 07/14] ixgbe: cleanup PHY init Jeff Kirsher
2011-03-08  2:25 ` [net-next-2.6 08/14] ixgbe: clear correct counters for flow control on 82599 Jeff Kirsher
2011-03-08  2:25 ` [net-next-2.6 09/14] ixgbe: Add x540 statistic counter definitions Jeff Kirsher
2011-03-08  2:25 ` [net-next-2.6 10/14] ixgbe: Enable flow control pause parameter auto-negotiation support Jeff Kirsher
2011-03-08  2:25 ` [net-next-2.6 11/14] ixgbe: add function description Jeff Kirsher
2011-03-08  2:25 ` Jeff Kirsher [this message]
2011-03-08  2:25 ` [net-next-2.6 13/14] ixgbe: fix spelling errors Jeff Kirsher
2011-03-08  2:25 ` [net-next-2.6 14/14] ixgbe: fix setting and reporting of advertised speeds Jeff Kirsher
2011-03-08 19:11 ` [net-next-2.6 00/14][pull request] Intel Wired LAN Driver Updates David Miller
2011-03-08 21:10   ` Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299551108-23663-13-git-send-email-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=bphilips@novell.com \
    --cc=davem@davemloft.net \
    --cc=emil.s.tantilov@intel.com \
    --cc=gospo@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).