From: Ben Hutchings <bhutchings@solarflare.com>
To: Tom Herbert <therbert@google.com>
Cc: "Michał Mirosław" <mirqus@gmail.com>,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] net: Allow no-cache copy from user on transmit
Date: Wed, 09 Mar 2011 19:38:31 +0000 [thread overview]
Message-ID: <1299699511.3006.6.camel@bwh-desktop> (raw)
In-Reply-To: <AANLkTiknMqNOQKiKpVaDy=zXCXuOxZaQTjKmmxY_bRC5@mail.gmail.com>
On Wed, 2011-03-09 at 11:18 -0800, Tom Herbert wrote:
> > Please don't add new get/set ops for netdev features - G/SFEATURES
> > handle them all.
> >
> > Proper way is to modify NETIF_F_ETHTOOL_BITS, netdev_fix_features()
> > and, if needed for now,
> > legacy get/set ops (they will go away, eventually).
> >
>
> Don't see this in
> git://git.kernel.org/pub/scm/network/ethtool/ethtool. Has the patch
> been applied?
I haven't changed ethtool yet. I put some patches out for discussion
and Michał found some problems for them; I haven't had the time to
revise them yet.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-03-09 19:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 5:05 [PATCH 1/2] net: Allow no-cache copy from user on transmit Tom Herbert
2011-03-09 6:12 ` Stephen Hemminger
2011-03-09 13:04 ` Michał Mirosław
2011-03-09 19:18 ` Tom Herbert
2011-03-09 19:38 ` Ben Hutchings [this message]
2011-03-09 19:51 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299699511.3006.6.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=mirqus@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox