* virtio_net: remove recv refill work?
@ 2011-03-10 21:03 Shirley Ma
2011-03-10 21:22 ` Shirley Ma
0 siblings, 1 reply; 2+ messages in thread
From: Shirley Ma @ 2011-03-10 21:03 UTC (permalink / raw)
To: Rusty Russell; +Cc: kvm, netdev, Michael S. Tsirkin
Hello Rusty,
What's the reason to use refill work in receiving path?
static void refill_work(struct work_struct *work)
{
struct virtnet_info *vi;
bool still_empty;
vi = container_of(work, struct virtnet_info, refill.work);
napi_disable(&vi->napi);
still_empty = !try_fill_recv(vi, GFP_KERNEL);
napi_enable(&vi->napi);
/* In theory, this can happen: if we don't get any buffers in
* we will *never* try to fill again. */
if (still_empty)
schedule_delayed_work(&vi->refill, HZ/2);
}
It looks more expensive than only refilling the buffers in recv path. It
could cause more guest exits, maybe more RX interrupts. Can we move the
refill work in recv path only?
If we can remove it, I will run some test to compare the difference with
the change.
Thanks
Shirley
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-10 21:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-10 21:03 virtio_net: remove recv refill work? Shirley Ma
2011-03-10 21:22 ` Shirley Ma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox