netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Dongli Zhang <dongli.zhang@oracle.com>,
	kvm@vger.kernel.org, netdev@vger.kernel.org
Cc: virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, mst@redhat.com
Subject: Re: [PATCH 1/1] vhost: change the signature of __vhost_get_user_slow()
Date: Wed, 15 Aug 2018 11:22:50 +0800	[thread overview]
Message-ID: <12b14053-b3ef-0616-6057-0406e7fd01bf@redhat.com> (raw)
In-Reply-To: <1534297600-2577-1-git-send-email-dongli.zhang@oracle.com>



On 2018年08月15日 09:46, Dongli Zhang wrote:
> Remove 'type' from the signature of __vhost_get_user_slow() as it is not
> used.
>
> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
> ---
>   drivers/vhost/vhost.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
> index ed31145..f78d3bc 100644
> --- a/drivers/vhost/vhost.c
> +++ b/drivers/vhost/vhost.c
> @@ -807,8 +807,7 @@ static int vhost_copy_from_user(struct vhost_virtqueue *vq, void *to,
>   }
>   
>   static void __user *__vhost_get_user_slow(struct vhost_virtqueue *vq,
> -					  void __user *addr, unsigned int size,
> -					  int type)
> +					  void __user *addr, unsigned int size)
>   {
>   	int ret;
>   
> @@ -846,7 +845,7 @@ static inline void __user *__vhost_get_user(struct vhost_virtqueue *vq,
>   	if (uaddr)
>   		return uaddr;
>   
> -	return __vhost_get_user_slow(vq, addr, size, type);
> +	return __vhost_get_user_slow(vq, addr, size);
>   }
>   
>   #define vhost_put_user(vq, x, ptr)		\

Please keep this as is.

It will be used by incoming packed virtqueue.

Thanks

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

      reply	other threads:[~2018-08-15  3:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-15  1:46 [PATCH 1/1] vhost: change the signature of __vhost_get_user_slow() Dongli Zhang
2018-08-15  3:22 ` Jason Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12b14053-b3ef-0616-6057-0406e7fd01bf@redhat.com \
    --to=jasowang@redhat.com \
    --cc=dongli.zhang@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).