From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AE5D3242AC for ; Tue, 23 Jun 2026 16:53:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782233640; cv=none; b=c4CxLeUlNFHFmXWnKjZnq2PY0cmGcVQByThRYmYaWj3vrYFGku20SVbCWujbK1oyrMeTlPasISD0V1ax6CXU9UzQiacSegRBvFGC5nCKG3Kz+OgpqiZldNWsX8+Wh6oMl0P5T8wLSTaggNsHjLysC4S0xuqwwmij5aiPlbks6Js= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782233640; c=relaxed/simple; bh=ldiRrZdBa6mW4oKMFxkyvPpg4R5eWCQxoVjoGq2HEGg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L4zdHZscWaf/LFM0fHuNGw7L1NG0G5DFQvXt8475cs9SbQ2wGMgxqI7IFkiKwQ4V7J17sGH13N/uiQLKieh1gtuL8yIAV4Pf9erxJeS4oulXDVDm3fkzfAvTFcq06ZA+F/jeg4PtXPBHRZqiArrIRbWxQHvez2bBvzU36mA55eQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=XYQ+4qmb; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="XYQ+4qmb" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id A8C3F4E40773; Tue, 23 Jun 2026 16:53:56 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 6AF8A601C2; Tue, 23 Jun 2026 16:53:56 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id BEDE3106C8382; Tue, 23 Jun 2026 18:53:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1782233635; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=z14O1Oxv2MwpgYnEYsps2OBdWGQ1E7SU6CsxbrKj0vc=; b=XYQ+4qmbXXeldrcn9HdaF60+1YlbI4oqajGsTyoZ3GOmFLAk8mbo9eEIGW387IITgwp/hh sqIzohPg5uC0vvhiKcYRo8zkzFRQsYknDD2eT7TO+scjLzEFnPc8LPi/gNX20DcCygj/2L DkZW5Jz6kME6LbEAxUP9N2MtjWGNdnSLCfDgqr9VZAl1LxqjihK2+PgWtmsctPyufJta+Z QaT31nsU1MLJNsHy7rVPnN4FCwhnegT/9XFBInRwmknfuZicE6kKrdYCYFuDLg9kfMDUkX j3K43D2pE51iCCQbjxEOjIFe9DKSg7BNrxq57syQNtK0zTAmUq9APdcO9jHM9Q== Message-ID: <12bb1713-d620-4db4-b240-fbc911be5ea3@bootlin.com> Date: Tue, 23 Jun 2026 18:53:48 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2 1/2] net: stmmac: dwmac-spacemit: Fix wrong phy interface definition To: Inochi Amaoto , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Yixun Lan , "Russell King (Oracle)" Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, Yixun Lan , Longbin Li References: <20260623074637.503864-1-inochiama@gmail.com> <20260623074637.503864-2-inochiama@gmail.com> Content-Language: en-US From: Maxime Chevallier In-Reply-To: <20260623074637.503864-2-inochiama@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hello, On 6/23/26 09:46, Inochi Amaoto wrote: > The current MII interface register definition from the vendor is wrong, > use the right number for the macro. Also, correct the interface mask > in spacemit_set_phy_intf_sel() so it can update the register with the > right number > > Fixes: 30f0ba420ed3 ("net: stmmac: Add glue layer for Spacemit K3 SoC") > Signed-off-by: Inochi Amaoto > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c > index 223754cc5c79..3bfb6d49be6c 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c > @@ -18,8 +18,10 @@ > #include "stmmac_platform.h" > > /* ctrl register bits */ > -#define CTRL_PHY_INTF_RGMII BIT(3) > -#define CTRL_PHY_INTF_MII BIT(4) > +#define CTRL_PHY_INTF_MODE GENMASK(4, 3) > +#define CTRL_PHY_INTF_RMII FIELD_PREP(CTRL_PHY_INTF_MODE, 0) > +#define CTRL_PHY_INTF_RGMII FIELD_PREP(CTRL_PHY_INTF_MODE, 1) > +#define CTRL_PHY_INTF_MII FIELD_PREP(CTRL_PHY_INTF_MODE, 3) > #define CTRL_WAKE_IRQ_EN BIT(9) > #define CTRL_PHY_IRQ_EN BIT(12) > > @@ -118,7 +120,7 @@ static void spacemit_get_interfaces(struct stmmac_priv *priv, void *bsp_priv, > > static int spacemit_set_phy_intf_sel(void *bsp_priv, u8 phy_intf_sel) > { > - unsigned int mask = CTRL_PHY_INTF_MII | CTRL_PHY_INTF_RGMII; > + unsigned int mask = CTRL_PHY_INTF_MODE; > struct spacmit_dwmac *dwmac = bsp_priv; > unsigned int val = 0; > > @@ -128,6 +130,7 @@ static int spacemit_set_phy_intf_sel(void *bsp_priv, u8 phy_intf_sel) > break; > > case PHY_INTF_SEL_RMII: > + val = CTRL_PHY_INTF_RMII; This isn't strictly-speaking necessary as this is 0 and val is already 0, maybe compilers can figure it out and this leaves us with more self-documenting code ? So I'm ok with that personally, Reviewed-by: Maxime Chevallier Maxime > break; > > case PHY_INTF_SEL_RGMII: