From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATH RFC net-next 7/8] net: phy: Replace phy driver features u32 with link_mode bitmap Date: Sat, 15 Sep 2018 14:31:14 -0700 Message-ID: <12e5b18f-400f-d4d0-aca3-4e4d8b4bb6a9@gmail.com> References: <1536961136-30453-1-git-send-email-andrew@lunn.ch> <1536961136-30453-8-git-send-email-andrew@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Andrew Lunn , netdev Return-path: Received: from mail-pl1-f194.google.com ([209.85.214.194]:34844 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727302AbeIPCvm (ORCPT ); Sat, 15 Sep 2018 22:51:42 -0400 Received: by mail-pl1-f194.google.com with SMTP id g2-v6so5703511plo.2 for ; Sat, 15 Sep 2018 14:31:17 -0700 (PDT) In-Reply-To: <1536961136-30453-8-git-send-email-andrew@lunn.ch> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 09/14/18 14:38, Andrew Lunn wrote: > This is one step in allowing phylib to make use of link_mode bitmaps, > instead of u32 for supported and advertised features. Convert the phy > drivers to use bitmaps to indicates the features they support. This > requires some macro magic in order to construct constant bitmaps used > to initialise the driver structures. > > Some new PHY_*_FEATURES are added, to indicate FIBRE is supported, and > that all media ports are supported. This is done since bitmaps cannot > be ORed together at compile time. > > Within phylib, the features bitmap is currently turned back into a > u32. The MAC API to phylib needs to be cleaned up before the core of > phylib can be converted to using bitmaps instead of u32. Nice! Reviewed-by: Florian Fainelli -- Florian