From: Martin KaFai Lau <martin.lau@linux.dev>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, kernel-team@meta.com
Subject: Re: [PATCH bpf-next 4/4] selftests/bpf: Add bpf_fib_lookup test
Date: Fri, 17 Feb 2023 15:08:33 -0800 [thread overview]
Message-ID: <12ea2782-5215-46ba-3687-575e91287309@linux.dev> (raw)
In-Reply-To: <CAEf4BzYL_K5Z3K-M394FeaQp87YozmqyUR8i=PaSfU7aCM=P+g@mail.gmail.com>
On 2/17/23 3:02 PM, Andrii Nakryiko wrote:
>> +#define SYS(fmt, ...) \
>> + ({ \
>> + char cmd[1024]; \
>> + snprintf(cmd, sizeof(cmd), fmt, ##__VA_ARGS__); \
>> + if (!ASSERT_OK(system(cmd), cmd)) \
>> + goto fail; \
>> + })
>
> it's probably a high time to move this SYS() macro into test_progs.h
> and stop copy/pasting it across many test?
Make sense. will follow up.
prev parent reply other threads:[~2023-02-17 23:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 0:41 [PATCH bpf-next 0/4] bpf: A fix and a change to bpf_fib_lookup Martin KaFai Lau
2023-02-17 0:41 ` [PATCH bpf-next 1/4] bpf: Disable bh in bpf_test_run for xdp and tc prog Martin KaFai Lau
2023-02-17 0:41 ` [PATCH bpf-next 2/4] bpf: bpf_fib_lookup should not return neigh in NUD_FAILED state Martin KaFai Lau
2023-02-17 0:41 ` [PATCH bpf-next 3/4] bpf: Add BPF_FIB_LOOKUP_SKIP_NEIGH for bpf_fib_lookup Martin KaFai Lau
2023-02-17 16:00 ` Daniel Borkmann
2023-02-17 17:13 ` Martin KaFai Lau
2023-02-17 0:41 ` [PATCH bpf-next 4/4] selftests/bpf: Add bpf_fib_lookup test Martin KaFai Lau
2023-02-17 23:02 ` Andrii Nakryiko
2023-02-17 23:08 ` Martin KaFai Lau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12ea2782-5215-46ba-3687-575e91287309@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@meta.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).