public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Zahka <daniel.zahka@gmail.com>
To: Wei Wang <weibunny.kernel@gmail.com>,
	netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
	Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	David Wei <dw@davidwei.uk>, Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Simon Horman <horms@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Wei Wang <weibunny@fb.com>
Subject: Re: [PATCH v13 net-next 2/5] psp: add new netlink cmd for dev-assoc and dev-disassoc
Date: Tue, 5 May 2026 10:07:14 -0400	[thread overview]
Message-ID: <12f11785-0bd5-400e-8acc-f47b92271e33@gmail.com> (raw)
In-Reply-To: <20260504230056.917415-3-weibunny.kernel@gmail.com>


On 5/4/26 7:00 PM, Wei Wang wrote:
> @@ -281,6 +318,34 @@ operations:
>           post: psp-device-unlock
>         dump:
>           reply: *stats-all
> +    -
> +      name: dev-assoc
> +      doc: Associate a network device with a PSP device.
> +      attribute-set: dev
> +      do:
> +        request:
> +          attributes:
> +            - id
> +            - ifindex
> +            - nsid
> +        reply:
> +          attributes: []
> +        pre: psp-device-get-locked
> +        post: psp-device-unlock
> +    -
> +      name: dev-disassoc
> +      doc: Disassociate a network device from a PSP device.
> +      attribute-set: dev
> +      do:
> +        request:
> +          attributes:
> +            - id
> +            - ifindex
> +            - nsid
> +        reply:
> +          attributes: []
> +        pre: psp-device-get-locked
> +        post: psp-device-unlock


Should these require flags: [admin-perm] and/or psp-device-get-locked-admin?



  reply	other threads:[~2026-05-05 14:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-04 23:00 [PATCH v13 net-next 0/5] psp: Add support for dev-assoc/disassoc Wei Wang
2026-05-04 23:00 ` [PATCH v13 net-next 1/5] psp: add admin/non-admin version of psp_device_get_locked Wei Wang
2026-05-04 23:00 ` [PATCH v13 net-next 2/5] psp: add new netlink cmd for dev-assoc and dev-disassoc Wei Wang
2026-05-05 14:07   ` Daniel Zahka [this message]
2026-05-06  0:06     ` Wei Wang
2026-05-04 23:00 ` [PATCH v13 net-next 3/5] psp: add a new netdev event for dev unregister Wei Wang
2026-05-04 23:00 ` [PATCH v13 net-next 4/5] selftests/net: Add bpf skb forwarding program Wei Wang
2026-05-04 23:00 ` [PATCH v13 net-next 5/5] selftests/net: psp: Add test for dev-assoc/disassoc Wei Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12f11785-0bd5-400e-8acc-f47b92271e33@gmail.com \
    --to=daniel.zahka@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dw@davidwei.uk \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=weibunny.kernel@gmail.com \
    --cc=weibunny@fb.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox