* [PATCH bpf] bpf: samples/sockmap fix Makefile for build error
@ 2018-02-13 4:42 Prashant Bhole
2018-02-14 1:48 ` Alexei Starovoitov
0 siblings, 1 reply; 3+ messages in thread
From: Prashant Bhole @ 2018-02-13 4:42 UTC (permalink / raw)
To: David S . Miller, Alexei Starovoitov, Daniel Borkmann
Cc: Prashant Bhole, John Fastabend, netdev
While building samples/sockmap, undefined reference error is thrown
for `nla_dump_errormsg'.
Linking tools/lib/bpf/nlattr.o as a fix
Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
---
samples/sockmap/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/samples/sockmap/Makefile b/samples/sockmap/Makefile
index 73f1da4d116c..9bf2881bd11b 100644
--- a/samples/sockmap/Makefile
+++ b/samples/sockmap/Makefile
@@ -2,7 +2,7 @@
hostprogs-y := sockmap
# Libbpf dependencies
-LIBBPF := ../../tools/lib/bpf/bpf.o
+LIBBPF := ../../tools/lib/bpf/bpf.o ../../tools/lib/bpf/nlattr.o
HOSTCFLAGS += -I$(objtree)/usr/include
HOSTCFLAGS += -I$(srctree)/tools/lib/
--
2.13.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH bpf] bpf: samples/sockmap fix Makefile for build error
2018-02-13 4:42 [PATCH bpf] bpf: samples/sockmap fix Makefile for build error Prashant Bhole
@ 2018-02-14 1:48 ` Alexei Starovoitov
2018-02-14 2:26 ` John Fastabend
0 siblings, 1 reply; 3+ messages in thread
From: Alexei Starovoitov @ 2018-02-14 1:48 UTC (permalink / raw)
To: Prashant Bhole
Cc: David S . Miller, Alexei Starovoitov, Daniel Borkmann,
John Fastabend, netdev
On Tue, Feb 13, 2018 at 01:42:49PM +0900, Prashant Bhole wrote:
> While building samples/sockmap, undefined reference error is thrown
> for `nla_dump_errormsg'.
> Linking tools/lib/bpf/nlattr.o as a fix
>
> Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
Applied to bpf-next, thanks Prashant!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH bpf] bpf: samples/sockmap fix Makefile for build error
2018-02-14 1:48 ` Alexei Starovoitov
@ 2018-02-14 2:26 ` John Fastabend
0 siblings, 0 replies; 3+ messages in thread
From: John Fastabend @ 2018-02-14 2:26 UTC (permalink / raw)
To: Alexei Starovoitov, Prashant Bhole
Cc: David S . Miller, Alexei Starovoitov, Daniel Borkmann, netdev
On 02/13/2018 05:48 PM, Alexei Starovoitov wrote:
> On Tue, Feb 13, 2018 at 01:42:49PM +0900, Prashant Bhole wrote:
>> While building samples/sockmap, undefined reference error is thrown
>> for `nla_dump_errormsg'.
>> Linking tools/lib/bpf/nlattr.o as a fix
>>
>> Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
>
> Applied to bpf-next, thanks Prashant!
>
Thanks!
Acked-by: John Fastabend <john.fastabend@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-14 2:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-13 4:42 [PATCH bpf] bpf: samples/sockmap fix Makefile for build error Prashant Bhole
2018-02-14 1:48 ` Alexei Starovoitov
2018-02-14 2:26 ` John Fastabend
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).