From: Sangtae Ha <sangtae.ha@gmail.com>
To: Lucas Nussbaum <lucas.nussbaum@loria.fr>
Cc: Stephen Hemminger <stephen.hemminger@vyatta.com>,
David Miller <davem@davemloft.net>, Injong Rhee <rhee@ncsu.edu>,
Bill Fink <billfink@mindspring.com>, <netdev@vger.kernel.org>,
Sangtae Ha <sangtae.ha@gmail.com>
Subject: [PATCH 1/3] tcp_cubic: fix train length comparision
Date: Sun, 13 Mar 2011 20:03:12 -0400 [thread overview]
Message-ID: <1300060992-24151-1-git-send-email-sangtae.ha@gmail.com> (raw)
HyStart detects the safe exit point when the ACK train length is
larger than the one-way delay. This needs to be applied after
the patches Stephen made to fix clock dependency of HyStart.
Signed-off-by: Sangtae Ha <sangtae.ha@gmail.com>
---
net/ipv4/tcp_cubic.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ipv4/tcp_cubic.c b/net/ipv4/tcp_cubic.c
index 91ef5e6..ab9f888 100644
--- a/net/ipv4/tcp_cubic.c
+++ b/net/ipv4/tcp_cubic.c
@@ -356,7 +356,7 @@ static void hystart_update(struct sock *sk, u32 delay)
/* first detection parameter - ack-train detection */
if ((s32)(now - ca->last_ack) <= hystart_ack_delta) {
ca->last_ack = now;
- if ((s32)(now - ca->round_start) <= ca->delay_min >> 4)
+ if ((s32)(now - ca->round_start) > ca->delay_min >> 4)
ca->found |= HYSTART_ACK_TRAIN;
}
--
1.7.0.4
reply other threads:[~2011-03-14 0:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300060992-24151-1-git-send-email-sangtae.ha@gmail.com \
--to=sangtae.ha@gmail.com \
--cc=billfink@mindspring.com \
--cc=davem@davemloft.net \
--cc=lucas.nussbaum@loria.fr \
--cc=netdev@vger.kernel.org \
--cc=rhee@ncsu.edu \
--cc=stephen.hemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).