public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Sangtae Ha <sangtae.ha@gmail.com>
To: Lucas Nussbaum <lucas.nussbaum@loria.fr>
Cc: Stephen Hemminger <stephen.hemminger@vyatta.com>,
	David Miller <davem@davemloft.net>, Injong Rhee <rhee@ncsu.edu>,
	Bill Fink <billfink@mindspring.com>, <netdev@vger.kernel.org>,
	Sangtae Ha <sangtae.ha@gmail.com>
Subject: [PATCH 3/3] tcp_cubic: fix low utilization of CUBIC with HyStart
Date: Sun, 13 Mar 2011 20:04:33 -0400	[thread overview]
Message-ID: <1300061073-24209-1-git-send-email-sangtae.ha@gmail.com> (raw)

HyStart sets the initial exit point of slow start.
Suppose that HyStart exits at 0.5BDP in a BDP network and no history exists.
If the BDP of a network is large, CUBIC's initial cwnd growth may be
too conservative to utilize the link.
CUBIC increases the cwnd 20% per RTT in this case.

Signed-off-by: Sangtae Ha <sangtae.ha@gmail.com>
---
 net/ipv4/tcp_cubic.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/net/ipv4/tcp_cubic.c b/net/ipv4/tcp_cubic.c
index b758db1..a170778 100644
--- a/net/ipv4/tcp_cubic.c
+++ b/net/ipv4/tcp_cubic.c
@@ -270,6 +270,15 @@ static inline void bictcp_update(struct bictcp *ca, u32 cwnd)
 		ca->cnt = 100 * cwnd;              /* very small increment*/
 	}
 
+	/*
+	 * The initial growth of cubic function may be too conservative
+	 * when the available bandwidth is still unknown.
+	 */
+	if (ca->loss_cwnd == 0) {
+		if (ca->cnt > 20)	/* increase cwnd 5% per RTT */
+			ca->cnt = 20;
+	}
+
 	/* TCP Friendly */
 	if (tcp_friendliness) {
 		u32 scale = beta_scale;
-- 
1.7.0.4


             reply	other threads:[~2011-03-14  0:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-14  0:04 Sangtae Ha [this message]
2011-03-14  0:07 ` [PATCH 3/3] tcp_cubic: fix low utilization of CUBIC with HyStart Sangtae Ha
2011-03-14  6:28   ` Lucas Nussbaum
2011-03-14  7:36     ` Sangtae Ha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300061073-24209-1-git-send-email-sangtae.ha@gmail.com \
    --to=sangtae.ha@gmail.com \
    --cc=billfink@mindspring.com \
    --cc=davem@davemloft.net \
    --cc=lucas.nussbaum@loria.fr \
    --cc=netdev@vger.kernel.org \
    --cc=rhee@ncsu.edu \
    --cc=stephen.hemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox