netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anders Franzen <anders.franzen@ericsson.com>
To: David Miller <davem@davemloft.net>
Cc: "Ian.Campbell@eu.citrix.com" <Ian.Campbell@eu.citrix.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] arp_notify: unconditionally send gratuitous ARP for NETDEV_NOTIFY_PEERS.
Date: Mon, 14 Mar 2011 10:26:39 +0100	[thread overview]
Message-ID: <1300094799.30687.5.camel@seasc7941> (raw)
In-Reply-To: <20110215.105114.226760606.davem@davemloft.net>

Nice, so this is a generic way of getting out gratuitous arps.
Can it be used by drivers (macvlan) on top of bonding.
Bonding is sending the BOND_FAILOVER event that could be mapped
to NOTIFY_PEERS in the higher level devices.

And bonding is implementing its own grat arps functions, maybe it could
be broken out to use the NOTIFY_PEERS instead.

And what about IPv6, would it be ok to implement an unsolicited NA on
the event?

I will happily implement the above, if anyone thinks it's worth it?

BR
 Anders


On Tue, 2011-02-15 at 19:51 +0100, David Miller wrote:
> From: Ian Campbell <Ian.Campbell@eu.citrix.com>
> Date: Tue, 15 Feb 2011 09:13:45 +0000
> 
> > On Tue, 2011-02-15 at 01:46 +0000, David Miller wrote:
> >> From: Ian Campbell <ian.campbell@citrix.com>
> >> Date: Fri, 11 Feb 2011 17:44:16 +0000
> >> 
> >> > NETDEV_NOTIFY_PEER is an explicit request by the driver to send a link
> >> > notification while NETDEV_UP/NETDEV_CHANGEADDR generate link
> >> > notifications as a sort of side effect.
>  ...
> > I nearly forgot -- the NETDEV_NOTIFY_PEER stuff was tagged for
> > stable/longterm backport (it appeared in 2.6.32.19 or so). I think this
> > change should likewise go back, what do you think?
> 
> Sure, I've queued it up for -stable.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



      reply	other threads:[~2011-03-14  9:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-11 17:44 [PATCH] arp_notify: unconditionally send gratuitous ARP for NETDEV_NOTIFY_PEERS Ian Campbell
2011-02-15  1:46 ` David Miller
2011-02-15  9:13   ` Ian Campbell
2011-02-15 18:51     ` David Miller
2011-03-14  9:26       ` Anders Franzen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300094799.30687.5.camel@seasc7941 \
    --to=anders.franzen@ericsson.com \
    --cc=Ian.Campbell@eu.citrix.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).