From: Eric Dumazet <eric.dumazet@gmail.com>
To: Daniel Turull <daniel.turull@gmail.com>
Cc: netdev@vger.kernel.org, Robert Olsson <robert@herjulf.net>,
Jens Laas <jens.laas@its.uu.se>,
Voravit Tanyingyong <voravit@kth.se>
Subject: Re: [PATCH] pktgen: fix transmission headers with frags=0
Date: Mon, 14 Mar 2011 15:18:58 +0100 [thread overview]
Message-ID: <1300112338.3423.27.camel@edumazet-laptop> (raw)
In-Reply-To: <4D7E22A5.1000708@gmail.com>
Le lundi 14 mars 2011 à 15:13 +0100, Daniel Turull a écrit :
> On 03/14/2011 02:56 PM, Eric Dumazet wrote:
> > Good catch !
> >
> > Hmm this patch is not correct, why memset(data + 1, ...) ?
>
> I kept the +1 as it was in the original code, but I supposed it can be avoided.
>
original code was assuming pgh was at right location.
pgh + 1 : really pointed to first byte after pktgen header.
data + 1 : points one byte off (so we leak one byte of kernel memory,
security guys would complain a lot...)
> I think that the second is better and more compact.
>
> Do I resend the new patch?
Yes please ;)
next prev parent reply other threads:[~2011-03-14 14:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 13:22 [PATCH] pktgen: fix transmission headers with frags=0 Daniel Turull
2011-03-14 13:56 ` Eric Dumazet
2011-03-14 14:13 ` Daniel Turull
2011-03-14 14:18 ` Eric Dumazet [this message]
2011-03-14 14:31 ` [PATCH net-next-2.6] pktgen: bug fix in " Daniel Turull
2011-03-14 14:35 ` Eric Dumazet
2011-03-14 20:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300112338.3423.27.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=daniel.turull@gmail.com \
--cc=jens.laas@its.uu.se \
--cc=netdev@vger.kernel.org \
--cc=robert@herjulf.net \
--cc=voravit@kth.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox