From: Ben Hutchings <bhutchings@solarflare.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
xen-devel <xen-devel@lists.xensource.com>,
"Jeremy Fitzhardinge" <jeremy@goop.org>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
"Francois Romieu" <romieu@fr.zoreil.com>,
"Stephen Hemminger" <shemminger@vyatta.com>,
"Michał Mirosław" <mirqus@gmail.com>
Subject: Re: [GIT/PATCH v5] xen network backend driver
Date: Mon, 14 Mar 2011 18:40:35 +0000 [thread overview]
Message-ID: <1300128035.2584.6.camel@bwh-desktop> (raw)
In-Reply-To: <1300112879.17339.2162.camel@zakaz.uk.xensource.com>
On Mon, 2011-03-14 at 14:27 +0000, Ian Campbell wrote:
> The following patch is the fifth iteration of the Xen network backend
> driver for upstream Linux.
>
> This driver ("netback") is the host side counterpart to the frontend
> driver in drivers/net/xen-netfront.c. The PV protocol is also
> implemented by frontend drivers in other OSes too, such as the BSDs and
> even Windows.
>
> Changes since the fourth posting, due to review from Stephen Hemminger:
> * Treat dev->features as u32 (it effectively is already and
> becomes literally so in net-next -- there's no harm in netback
> switching earlier)
> * Use stats from struct netdevice instead of a local copy.
[...]
All looks good (or good enough) to me. I would add Reviewed-by, but
this isn't a single patch.
I know you have asked for this to be pulled, in order to retain its
history, but I'm not sure that David Miller will do this unless the
driver is at least buildable at each stage in the history. (However,
given that the driver wouldn't be enabled before it's added, I'm not
sure it matters in this case.)
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-03-14 18:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 14:27 [GIT/PATCH v5] xen network backend driver Ian Campbell
2011-03-14 18:40 ` Ben Hutchings [this message]
2011-03-14 19:30 ` Ian Campbell
2011-03-14 20:23 ` David Miller
2011-03-14 22:17 ` Ian Campbell
2011-03-14 22:22 ` David Miller
2011-03-15 7:09 ` Ian Campbell
2011-03-15 10:06 ` Ian Campbell
2011-03-14 18:57 ` Eric Dumazet
2011-03-14 19:33 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300128035.2584.6.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=Ian.Campbell@citrix.com \
--cc=herbert@gondor.apana.org.au \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=mirqus@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=shemminger@vyatta.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).