From: Ian Campbell <Ian.Campbell@eu.citrix.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
xen-devel <xen-devel@lists.xensource.com>,
"Jeremy Fitzhardinge" <jeremy@goop.org>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
"Francois Romieu" <romieu@fr.zoreil.com>,
"Ben Hutchings" <bhutchings@solarflare.com>,
"Stephen Hemminger" <shemminger@vyatta.com>,
"Michał Mirosław" <mirqus@gmail.com>
Subject: Re: [GIT/PATCH v5] xen network backend driver
Date: Mon, 14 Mar 2011 19:33:28 +0000 [thread overview]
Message-ID: <1300131208.32696.24.camel@localhost.localdomain> (raw)
In-Reply-To: <1300129032.3423.170.camel@edumazet-laptop>
On Mon, 2011-03-14 at 18:57 +0000, Eric Dumazet wrote:
> Le lundi 14 mars 2011 à 14:27 +0000, Ian Campbell a écrit :
> > + /* Statistics */
> > + unsigned long rx_gso_checksum_fixup;
>
> this is an "unsigned long" field
> > +static void xenvif_get_ethtool_stats(struct net_device *dev,
> > + struct ethtool_stats *stats, u64 * data)
> > +{
> > + void *vif = netdev_priv(dev);
> > + int i;
> > +
> > + for (i = 0; i < ARRAY_SIZE(xenvif_stats); i++)
> > + data[i] = *(int *)(vif + xenvif_stats[i].offset);
>
> so use : data[i] = *(unsigned long *)(vif + xenvif_stats[i].offset);
Oops, will do, thanks.
Ian.
prev parent reply other threads:[~2011-03-14 19:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 14:27 [GIT/PATCH v5] xen network backend driver Ian Campbell
2011-03-14 18:40 ` Ben Hutchings
2011-03-14 19:30 ` Ian Campbell
2011-03-14 20:23 ` David Miller
2011-03-14 22:17 ` Ian Campbell
2011-03-14 22:22 ` David Miller
2011-03-15 7:09 ` Ian Campbell
2011-03-15 10:06 ` Ian Campbell
2011-03-14 18:57 ` Eric Dumazet
2011-03-14 19:33 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300131208.32696.24.camel@localhost.localdomain \
--to=ian.campbell@eu.citrix.com \
--cc=bhutchings@solarflare.com \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=mirqus@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=shemminger@vyatta.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).