From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jonathan Morton <chromatix99@gmail.com>
Cc: "Dave Täht" <d@taht.net>, "David Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>
Subject: Re: ECN + pfifo_fast borked? (Was Re: [Bloat] shaper team forming up)
Date: Tue, 15 Mar 2011 20:56:59 +0100 [thread overview]
Message-ID: <1300219019.2565.1.camel@edumazet-laptop> (raw)
In-Reply-To: <7CFAAB08-8A30-4569-8825-64121D43EA77@gmail.com>
Le mardi 15 mars 2011 à 20:37 +0200, Jonathan Morton a écrit :
> On 15 Mar, 2011, at 8:28 pm, Eric Dumazet wrote:
>
> >>> band 0 : high priority packets (like now)
> >>> band 1 : (old band 1, ECN capable flows)
> >>> band 2 : (old band 1, no ECN flows)
> >>> band 3 : low priority packets (old band 2)
> >>
> >> This seems good to me. It would provide a concrete (if minor) enticement to turn ECN on.
> >
> > Here is a patch to implement that, on top of net-next-2.6 git tree
>
> Does this take both ECN bits into account? The ECT(0), ECT(1) and ECE codepoints all need to be recognised equally.
This is done in a different layer, as already explained.
Current linux code ignores low order bit when doing TOS -> skb->priority
mapping.
next prev parent reply other threads:[~2011-03-15 19:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87wrk1a4gx.fsf@cruithne.co.teklibre.org>
[not found] ` <5BC42741-852B-4699-BA5D-D70B8D610D96@gmail.com>
2011-03-14 20:24 ` [Bloat] shaper team forming up Eric Dumazet
2011-03-15 4:42 ` Eric Dumazet
2011-03-15 5:27 ` ECN + pfifo_fast borked? (Was Re: [Bloat] shaper team forming up) Dave Täht
2011-03-15 6:15 ` Eric Dumazet
2011-03-15 17:09 ` Jonathan Morton
2011-03-15 18:28 ` Eric Dumazet
2011-03-15 18:37 ` Jonathan Morton
2011-03-15 19:56 ` Eric Dumazet [this message]
2011-03-15 22:51 ` [Bloat] shaper team forming up David Miller
2011-03-15 22:53 ` David Miller
2011-03-15 23:00 ` Eric Dumazet
2011-03-15 23:56 ` [PATCH] net_sched: fix ip_tos2prio Eric Dumazet
2011-03-16 1:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300219019.2565.1.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=chromatix99@gmail.com \
--cc=d@taht.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox