Re: [PATCH net-next-2.6] ftmac100: use GFP_ATOMIC allocations where needed

Po-Yu Chuang
2011-03-14T08:16:27Z

Hi Eric,

On Mon, Mar 14, 2011 at 4:29 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Le dimanche 13 mars 2011 à 21:26 +0100, Eric Dumazet a écrit :
>> Le dimanche 13 mars 2011 à 21:16 +0100, Eric Dumazet a écrit :
>>
>> > BTW, it seems I missed the fact that ftmac100_alloc_rx_page() used a
>> > GFP_KERNEL allocation, while its called from softirq context (from
>> > ftmac100_rx_packet())
>>
>> Here is a patch against ftmac100
>>
>
> Oops, one typo in it sorry
>
>> -static int ftmac100_alloc_rx_page(struct ftmac100 *priv, struct ftmac100_rxdes *rxdes)
>> +static int ftmac100_alloc_rx_page(struct ftmac100 *priv,
>> +                               struct ftmac100_rxdes *rxdes, gtp_t gfp)
>
> Should be :   gfp_t gfp
>
> Please build and test the patch, I dont have an ARM testbed anyway.

Tested-by: Po-Yu Chuang <ratbert@faraday-tech.com>

Thank you,
Po-Yu Chuang