Re: [PATCH v2] net: add Faraday FTGMAC100 Gigabit Ethernet driver

Po-Yu Chuang
2011-03-21T07:55:02Z

Hi Eric,

On Thu, Mar 17, 2011 at 7:30 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Le jeudi 17 mars 2011 à 18:56 +0800, Po-Yu Chuang a écrit :
>> On Thu, Mar 17, 2011 at 6:24 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> > Le jeudi 17 mars 2011 à 17:47 +0800, Po-Yu Chuang a écrit :
>> >> From: Po-Yu Chuang <ratbert@faraday-tech.com>
>> >>
>> >> FTGMAC100 Ethernet Media Access Controller supports 10/100/1000 Mbps
>> >> and MII/GMII.  This driver has been working on some ARM/NDS32 SoC's
>> >> including Faraday A369 and Andes AG102.
>> >>
>> >> Signed-off-by: Po-Yu Chuang <ratbert@faraday-tech.com>
>> >> ---
>> >
>> > Did you tried GRO support ?
>>
>> No, I don't understand how to do that yet. Let me do some study first.
>> I'd really appreciate it if you could provide me some pointers about GRO. :-)
>> Is there any document about it?
>
> Should be easy and might help performance too.
>
> Take a look at commit :
>
> 2edae08e5b75269855fef3c74fe4292c066e7c33 (r8169: add gro support)

It seems to work fine so far at least the driver is not broken, but I did not
see much difference in performance though. How do I know if GRO is
working indeed?

Best regards,
Po-Yu Chuang