From: Shirley Ma <mashirle@us.ibm.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
David Miller <davem@davemloft.net>,
kvm@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] virtio_net: remove send completion interrupts and avoid TX queue overrun through packet drop
Date: Thu, 17 Mar 2011 08:10:05 -0700 [thread overview]
Message-ID: <1300374605.3255.43.camel@localhost.localdomain> (raw)
In-Reply-To: <874o72gwm5.fsf@rustcorp.com.au>
On Thu, 2011-03-17 at 15:40 +1030, Rusty Russell wrote:
> This is fascinating... and deeply weird.
>
> OK, what's the difference between calling xmit_skb and ignoring
> failure,
> and this patch which figures out it's going to fail before calling
> xmit_skb?
>
> ie. what if you *just* delete this:
Somehow what was in my mind, add_buf is more expensive than simply
checked ring capacity. I retest it with your and Michael's suggestion
here.
Thanks
Shirley
next prev parent reply other threads:[~2011-03-17 15:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 0:12 [PATCH 2/2] virtio_net: remove send completion interrupts and avoid TX queue overrun through packet drop Shirley Ma
2011-03-17 5:02 ` Michael S. Tsirkin
2011-03-17 15:18 ` Shirley Ma
2011-03-18 3:28 ` Shirley Ma
2011-03-18 13:15 ` Michael S. Tsirkin
2011-03-18 16:54 ` Shirley Ma
2011-03-17 5:10 ` Rusty Russell
2011-03-17 15:10 ` Shirley Ma [this message]
2011-03-18 13:33 ` Herbert Xu
2011-03-19 1:41 ` Shirley Ma
2011-03-21 18:03 ` Shirley Ma
2011-03-22 11:36 ` Michael S. Tsirkin
2011-03-23 2:26 ` Shirley Ma
2011-03-24 0:30 ` Rusty Russell
2011-03-24 4:14 ` Shirley Ma
2011-03-24 14:28 ` Michael S. Tsirkin
2011-03-24 17:46 ` Shirley Ma
2011-03-24 18:10 ` Michael S. Tsirkin
2011-03-25 4:51 ` Rusty Russell
2011-03-25 4:50 ` Rusty Russell
2011-03-27 7:52 ` Michael S. Tsirkin
2011-04-04 6:13 ` Rusty Russell
2011-03-24 0:16 ` Rusty Russell
2011-03-24 6:39 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300374605.3255.43.camel@localhost.localdomain \
--to=mashirle@us.ibm.com \
--cc=davem@davemloft.net \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).