Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jerry Chu <hkchu@google.com>
Cc: Stephen Hemminger <shemminger@vyatta.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] Add useful per-connection TCP stats for diagnosis purpose.
Date: Fri, 18 Mar 2011 07:05:24 +0100	[thread overview]
Message-ID: <1300428324.2881.5.camel@edumazet-laptop> (raw)
In-Reply-To: <AANLkTi=W-=8zhQpfJZ=DrDyUCwrT==5JkwRBiHaDkVXK@mail.gmail.com>

Le jeudi 17 mars 2011 à 21:33 -0700, Jerry Chu a écrit :

> Yes I'm familiar with ss and how inet_csk_diag_fill() calls into
> tcp_diag_get_info(),..., etc. Like I mentioned previously the netlink
> interface
> requires a new version of reader app (e.g., ss) to ship every time a new
> counter is added and exported by the kernel, whereas /proc/net/tcp does
> not have such a problem.
> 
> Anyway I can add a INET_DIAG_INFO_EXT of some sort to netlink in
> addition to /proc/net/tcp. That's easy to do.
> 

I suggest adding a getsockopt() or something to gather stats for one
socket. On a loaded machine, /proc/net/tcp is damn slow.

We have TCP_INFO, we could add TCP_INFO_EXT, but taking care of choosing
an interface allowing for extension of the structure.




  parent reply	other threads:[~2011-03-18  6:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-17  8:06 [PATCH] Add useful per-connection TCP stats for diagnosis purpose H.K. Jerry Chu
2011-03-17  8:42 ` Eric Dumazet
2011-03-17 20:16   ` Jerry Chu
2011-03-17 21:20     ` Stephen Hemminger
2011-03-18  4:33       ` Jerry Chu
2011-03-18  4:51         ` David Miller
2011-03-18  6:05         ` Eric Dumazet [this message]
2011-03-19  4:33           ` Jerry Chu
2011-03-19  5:02             ` Eric Dumazet
2011-03-19  5:38               ` Jerry Chu
2011-03-19  6:03                 ` Eric Dumazet
2011-03-20  7:30                   ` Jerry Chu
2011-03-20  9:18                     ` Eric Dumazet
2011-03-21 21:18             ` Stephen Hemminger
2011-03-21 22:19               ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300428324.2881.5.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=hkchu@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox