From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: patch for format issues and header bug in net/ipv4/icmp.c Date: Fri, 18 Mar 2011 19:41:01 +0000 Message-ID: <1300477261.2589.28.camel@bwh-desktop> References: <20110318183529.GA3617@debian.Jeff> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , Alexey Kuznetsov , linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: Jeffrin Jose Return-path: In-Reply-To: <20110318183529.GA3617@debian.Jeff> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Sat, 2011-03-19 at 00:05 +0530, Jeffrin Jose wrote: > hello , > > I have created a patch for net/ipv4/icmp.c > using checkpatch.pl script to fix several warnings > and an error. You need to learn C programming before trying to correct C programs. You should not just do what it takes to make checkpatch.pl happy. Ben. > I have attached the patch along with this mail. > > /Thanks > -- Ben Hutchings, Senior Software Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.