From: Ben Hutchings <bhutchings@solarflare.com>
To: Ajit Khaparde <ajit.khaparde@emulex.com>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC] ethtool: Display reg dump length via get driver info.
Date: Fri, 18 Mar 2011 21:32:19 +0000 [thread overview]
Message-ID: <1300483939.2589.46.camel@bwh-desktop> (raw)
In-Reply-To: <ae232d9a-90c7-47ae-856d-bc5a2b3a8037@exht1.ad.emulex.com>
On Fri, 2011-03-18 at 16:06 -0500, Ajit Khaparde wrote:
> Devices like BE store Reg Dump Data in the hardware.
Where else would it be?
> This change will allow to just peek into the hardware
> to see if any data is available for a dump and analysis,
> without actually dumping the register data.
[...]
This is wrong. ethtool_ops::get_regs_len really should return a
constant, otherwise ethtool (and the kernel) cannot allocate a buffer of
the right size. If the size of a dump really does vary then make it
return the maximum possible size for the device.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-03-18 21:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 21:06 [RFC] ethtool: Display reg dump length via get driver info Ajit Khaparde
2011-03-18 21:32 ` Ben Hutchings [this message]
2011-03-18 21:52 ` Ajit.Khaparde
2011-03-18 22:00 ` Ben Hutchings
2011-03-18 22:07 ` Ajit.Khaparde
2011-03-18 22:44 ` [PATCH ethtool] ethtool: Report driver features described in struct ethtool_drvinfo Ben Hutchings
2011-03-19 8:04 ` Ajit.Khaparde
2011-03-23 17:18 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300483939.2589.46.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=ajit.khaparde@emulex.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox